Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sqllogictest requirement from 0.24.0 to 0.25.0 #13917

Merged
merged 2 commits into from
Dec 28, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 27, 2024

Updates the requirements on sqllogictest to permit the latest version.

Release notes

Sourced from sqllogictest's releases.

v0.25.0

[0.25.0] - 2024-12-26

  • runner: Add retry clause to statement ok and query ok|error.
Changelog

Sourced from sqllogictest's changelog.

[0.25.0] - 2024-12-26

  • runner: Add retry clause to statement ok and query ok|error.

[0.24.0] - 2024-12-20

  • runner: Added a Normalizer type for normalizing result values. A new function with_normalizer(normalizer: Normalizer) has been added to the Runner to allow for specifying a custom Normalizer. The existing default normalizer is available via the runner::default_normalizer(..) function.
  • parser: Added a new control mode resultmode that controls whether the results are in valuewise or columnwise mode. The default is columnwise which means results are in columns. valuewise means the results are in a single column (sqlite test style).
  • parser: Added valuesortsort mode. The valuesort mode works like rowsort except that it does not honor row groupings. Each individual result value is sorted on its own.

Breaking change:

  • The Validator type used in various function in Runner implementation has a new required field Normalizer that is used to normalize result values.

[0.23.1] - 2024-12-13

  • feat(bin): add opt --keep-db-on-failure

[0.23.0] - 2024-11-16

  • Refine the behavior of update_record_with_output / --override
    • runner: Previously, query returning 0 rows will become statement ok. Now it returns statement count 0.
    • bin: Now --override will not change the type chars of query <types>, since in practice it becomes ?s which might cause confusion.
  • runner: statement count <n> is incorrectly handled when the result is a query.

[0.22.1] - 2024-11-11

  • engines/bin: fix compatibility with the new tokio-postgres minor version.

[0.22.0] - 2024-09-09

  • engines/bin: support MySQL engine

[0.21.0] - 2024-06-30

Breaking changes:

  • runner: RecordOutput is now returned by Runner::run (or Runner::run_async). This allows users to access the output of each record, or check whether the record is skipped.
  • runner(substitution): add a special variable __NOW__ which will be replaced with the current Unix timestamp in nanoseconds.
  • runner(substitution): for system commands, we do not substitute environment variables any more, because the shell

... (truncated)

Commits

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Updates the requirements on [sqllogictest](https://github.com/risinglightdb/sqllogictest-rs) to permit the latest version.
- [Release notes](https://github.com/risinglightdb/sqllogictest-rs/releases)
- [Changelog](https://github.com/risinglightdb/sqllogictest-rs/blob/main/CHANGELOG.md)
- [Commits](risinglightdb/sqllogictest-rs@v0.24.0...v0.25.0)

---
updated-dependencies:
- dependency-name: sqllogictest
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@github-actions github-actions bot added the sqllogictest SQL Logic Tests (.slt) label Dec 27, 2024
@@ -80,7 +80,7 @@ SELECT col1 * cor0.col1 * 56 AS col1 FROM tab2 AS cor0 GROUP BY cor0.col1
208376
94136

query I rowsort label-4
query I rowsort
Copy link
Member

@jonahgao jonahgao Dec 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These tests come from sqlite, where label is the syntax of sqlite, used to verify that queries with the same label yield the same result. Within this SLT, we don't have the same labels, so this is meaningless. Additionally, sqllogictest-rs does not support this syntax.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI it turns out that these labels are used in the sqllite test suite so I made a PR to revert this upgrade temporarily until this feature is restored:

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @dependabot and @jonahgao

fyi @Omega359

@alamb alamb merged commit 0989649 into main Dec 28, 2024
52 checks passed
@dependabot dependabot bot deleted the dependabot/cargo/main/sqllogictest-0.25.0 branch December 28, 2024 14:37
Omega359 pushed a commit to Omega359/arrow-datafusion that referenced this pull request Dec 28, 2024
* Update sqllogictest requirement from 0.24.0 to 0.25.0

Updates the requirements on [sqllogictest](https://github.com/risinglightdb/sqllogictest-rs) to permit the latest version.
- [Release notes](https://github.com/risinglightdb/sqllogictest-rs/releases)
- [Changelog](https://github.com/risinglightdb/sqllogictest-rs/blob/main/CHANGELOG.md)
- [Commits](risinglightdb/sqllogictest-rs@v0.24.0...v0.25.0)

---
updated-dependencies:
- dependency-name: sqllogictest
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>

* Remove labels

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: jonahgao <[email protected]>
alamb added a commit to alamb/datafusion that referenced this pull request Dec 30, 2024
jonahgao pushed a commit that referenced this pull request Dec 30, 2024
…" (#13945)

* Revert "Update sqllogictest requirement from 0.24.0 to 0.25.0 (#13917)"

This reverts commit 0989649.

* add comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-dependencies sqllogictest SQL Logic Tests (.slt)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants