Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sqllogictest requirement from 0.24.0 to 0.25.0 #13917

Merged
merged 2 commits into from
Dec 28, 2024
Merged

Update sqllogictest requirement from 0.24.0 to 0.25.0 #13917

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8ac3705
Update sqllogictest requirement from 0.24.0 to 0.25.0
dependabot[bot] Dec 27, 2024
6c6085b
Remove labels
jonahgao Dec 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion datafusion/sqllogictest/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ object_store = { workspace = true }
postgres-protocol = { version = "0.6.7", optional = true }
postgres-types = { version = "0.2.8", features = ["derive", "with-chrono-0_4"], optional = true }
rust_decimal = { version = "1.36.0", features = ["tokio-pg"] }
sqllogictest = "0.24.0"
sqllogictest = "0.25.0"
sqlparser = { workspace = true }
tempfile = { workspace = true }
thiserror = "2.0.0"
Expand Down
16 changes: 8 additions & 8 deletions datafusion/sqllogictest/test_files/group_by.slt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ SELECT col1 * cor0.col1 * 56 AS col1 FROM tab2 AS cor0 GROUP BY cor0.col1
208376
94136

query I rowsort label-4
query I rowsort
Copy link
Member

@jonahgao jonahgao Dec 28, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These tests come from sqlite, where label is the syntax of sqlite, used to verify that queries with the same label yield the same result. Within this SLT, we don't have the same labels, so this is meaningless. Additionally, sqllogictest-rs does not support this syntax.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI it turns out that these labels are used in the sqllite test suite so I made a PR to revert this upgrade temporarily until this feature is restored:

SELECT ALL + tab2.col1 / tab2.col1 FROM tab2 GROUP BY col1
----
1
Expand Down Expand Up @@ -442,7 +442,7 @@ SELECT DISTINCT * FROM tab2 AS cor0 GROUP BY cor0.col0, col1, cor0.col2
91 59 79
92 41 58

query I rowsort label-58
query I rowsort
SELECT 9 / + cor0.col0 AS col1 FROM tab0 AS cor0 GROUP BY cor0.col0, cor0.col2
----
0
Expand Down Expand Up @@ -470,7 +470,7 @@ SELECT ( col0 ) FROM tab1 AS cor0 GROUP BY cor0.col0
28
82

query I rowsort label-62
query I rowsort
SELECT ALL 59 / 26 FROM tab2 AS cor0 GROUP BY cor0.col0
----
2
Expand Down Expand Up @@ -558,7 +558,7 @@ SELECT DISTINCT ( - 31 ) col1 FROM tab1 GROUP BY tab1.col0
----
-31

query I rowsort label-75
query I rowsort
SELECT + + cor0.col0 / - cor0.col0 FROM tab1, tab0 AS cor0 GROUP BY cor0.col0
----
-1
Expand Down Expand Up @@ -767,7 +767,7 @@ SELECT cor0.col2 AS col2 FROM tab0 AS cor0 GROUP BY cor0.col2
38
79

query I rowsort label-106
query I rowsort
SELECT - 53 / cor0.col0 col0 FROM tab1 cor0 GROUP BY cor0.col0
----
-1
Expand Down Expand Up @@ -1326,7 +1326,7 @@ SELECT + ( col0 ) * col0 AS col2 FROM tab2 AS cor0 GROUP BY cor0.col0
8281
8464

query I rowsort label-188
query I rowsort
SELECT - 21 - + 57 / cor0.col0 FROM tab0 AS cor0 GROUP BY cor0.col0
----
-21
Expand Down Expand Up @@ -1429,7 +1429,7 @@ SELECT cor0.col2 FROM tab2 AS cor0 GROUP BY cor0.col2
79
87

query I rowsort label-203
query I rowsort
SELECT - cor0.col2 + CAST ( 80 AS INTEGER ) FROM tab1 AS cor0 GROUP BY col2
----
35
Expand Down Expand Up @@ -1482,7 +1482,7 @@ SELECT DISTINCT + 45 col0 FROM tab1 AS cor0 GROUP BY col0
----
45

query I rowsort label-211
query I rowsort
SELECT ALL CAST ( NULL AS INTEGER ) FROM tab2 AS cor0 GROUP BY col1
----
NULL
Expand Down
Loading