Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment and documentation improvement #3943

Merged
merged 11 commits into from
Sep 5, 2024

Conversation

aidinio
Copy link
Contributor

@aidinio aidinio commented Aug 20, 2024

I tried to make some details in the documentation more explicit.

@aidinio aidinio requested review from actionless and Aire-One August 26, 2024 00:46
@actionless
Copy link
Member

@aidinio
Copy link
Contributor Author

aidinio commented Aug 26, 2024

https://github.com/awesomeWM/awesome/actions/runs/10548999597/job/29229634679?pr=3943

Thanks for the hint. I fixed the problem.

lib/wibox/widget/slider.lua Outdated Show resolved Hide resolved
aidinio and others added 2 commits September 4, 2024 19:43
a new file named 'cursor_c_lua.ldoc' which uses awesome comments
syntax, because the existing 'cursor_c.ldoc' could not be compiled.
actionless
actionless previously approved these changes Sep 4, 2024
Copy link
Contributor Author

@aidinio aidinio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found

@@ -0,0 +1,80 @@
-- <div class='flex-list'>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should be named cursor.ldoc. the _c is to indicate the comments syntax is C style instead of Lua.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, should the files /docs/common/client_theme.ldoc and /docs/common/cobject.ldoc have the _c suffix too?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair point. Let's just ignore my comment then because making these filenames more consistent is out of the scope of this PR 🤷

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah you did the change for this file anyway. Nice 👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah you did the change for this file anyway. Nice 👍

Thanks. I might open another PR for changing those file names.

docs/common/cursor_c_lua.ldoc Outdated Show resolved Hide resolved
lib/wibox/widget/slider.lua Outdated Show resolved Hide resolved
@actionless actionless merged commit 03285e8 into awesomeWM:master Sep 5, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants