Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment and documentation improvement #3943

Merged
merged 11 commits into from
Sep 5, 2024
80 changes: 80 additions & 0 deletions docs/common/cursor_c_lua.ldoc
Original file line number Diff line number Diff line change
@@ -0,0 +1,80 @@
-- <div class='flex-list'>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should be named cursor.ldoc. the _c is to indicate the comments syntax is C style instead of Lua.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, should the files /docs/common/client_theme.ldoc and /docs/common/cobject.ldoc have the _c suffix too?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair point. Let's just ignore my comment then because making these filenames more consistent is out of the scope of this PR 🤷

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah you did the change for this file anyway. Nice 👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah you did the change for this file anyway. Nice 👍

Thanks. I might open another PR for changing those file names.

aidinio marked this conversation as resolved.
Show resolved Hide resolved
-- <div>num\_glyphs</div>
-- <div>arrow</div>
-- <div>based\_arrow\_down</div>
-- <div>based\_arrow\_up</div>
-- <div>boat</div>
-- <div>bogosity</div>
-- <div>bottom\_left\_corner</div>
-- <div>bottom\_right\_corner</div>
-- <div>bottom\_side</div>
-- <div>bottom\_tee</div>
-- <div>box\_spiral</div>
-- <div>center\_ptr</div>
-- <div>circle</div>
-- <div>clock</div>
-- <div>coffee\_mug</div>
-- <div>cross</div>
-- <div>crosshair</div>
-- <div>cross\_reverse</div>
-- <div>cursor</div>
-- <div>diamond\_cross</div>
-- <div>dotbox</div>
-- <div>dot</div>
-- <div>double\_arrow</div>
-- <div>draft\_large</div>
-- <div>draft\_small</div>
-- <div>draped\_box</div>
-- <div>exchange</div>
-- <div>fleur</div>
-- <div>gobbler</div>
-- <div>gumby</div>
-- <div>hand</div>
-- <div>hand</div>
-- <div>heart</div>
-- <div>icon</div>
-- <div>iron\_cross</div>
-- <div>leftbutton</div>
-- <div>left\_ptr</div>
-- <div>left\_side</div>
-- <div>left\_tee</div>
-- <div>ll\_angle</div>
-- <div>lr\_angle</div>
-- <div>man</div>
-- <div>middlebutton</div>
-- <div>mouse</div>
-- <div>pencil</div>
-- <div>pirate</div>
-- <div>plus</div>
-- <div>question\_arrow</div>
-- <div>rightbutton</div>
-- <div>right\_ptr</div>
-- <div>right\_side</div>
-- <div>right\_tee</div>
-- <div>rtl\_logo</div>
-- <div>sailboat</div>
-- <div>sb\_down\_arrow</div>
-- <div>sb\_h\_double\_arrow</div>
-- <div>sb\_left\_arrow</div>
-- <div>sb\_right\_arrow</div>
-- <div>sb\_up\_arrow</div>
-- <div>sb\_v\_double\_arrow</div>
-- <div>shuttle</div>
-- <div>sizing</div>
-- <div>spider</div>
-- <div>spraycan</div>
-- <div>star</div>
-- <div>target</div>
-- <div>tcross</div>
-- <div>top\_left\_arrow</div>
-- <div>top\_left\_corner</div>
-- <div>top\_right\_corner</div>
-- <div>top\_side</div>
-- <div>top\_tee</div>
-- <div>trek</div>
-- <div>ul\_angle</div>
-- <div>umbrella</div>
-- <div>ur\_angle</div>
-- <div>watch</div>
-- <div>xterm</div>
-- </div>
6 changes: 3 additions & 3 deletions lib/gears/timer.lua
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ end
-- @see start
-- @see stop

--- The timer timeout value.
--- The timer timeout value in seconds.
aidinio marked this conversation as resolved.
Show resolved Hide resolved
--
-- @property timeout
-- @tparam[opt=0] number timeout
Expand Down Expand Up @@ -182,8 +182,8 @@ local timer_instance_mt = {
--
-- @tparam table args Arguments.
-- @tparam number args.timeout Timeout in seconds (e.g. `1.5`).
-- @tparam[opt=false] boolean args.autostart Automatically start the timer.
-- @tparam[opt=false] boolean args.call_now Call the callback at timer creation.
-- @tparam[opt=false] boolean args.autostart Immediately start the timer countdown.
-- @tparam[opt=false] boolean args.call_now Immediately call the callback function.
-- @tparam[opt] function args.callback Callback function to connect to the
-- "timeout" signal.
-- @tparam[opt=false] boolean args.single_shot Run only once then stop.
Expand Down
6 changes: 3 additions & 3 deletions lib/wibox/widget/graph.lua
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
---------------------------------------------------------------------------
--- Display multiple values as a stream of bars.
--
-- The graph goes from left to right. To change this to right to left, use
-- a `wibox.container.mirror` widget. This can also be used to have data
-- shown from top to bottom.
-- The graph goes from left to right. To change the movement's direction,
-- use a `wibox.container.mirror` widget. This can also be used to have
-- data shown from top to bottom.
--
-- To add text on top of the graph, use a `wibox.layout.stack` and a
-- `wibox.container.align` widgets.
Expand Down
2 changes: 1 addition & 1 deletion lib/wibox/widget/separator.lua
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---------------------------------------------------------------------------
-- A flexible separator widget.
--
-- By default, this widget display a simple line, but can be extended by themes
-- By default, this widget displays a simple line, but can be extended by themes
-- (or directly) to display much more complex visuals.
--
-- This widget is mainly intended to be used alongside the `spacing_widget`
Expand Down
15 changes: 12 additions & 3 deletions lib/wibox/widget/slider.lua
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,11 @@ local slider = {mt={}}
-- @propemits true false
-- @propbeautiful

--- The handle grab cursor.
--- The cursor icon while grabbing the handle.
-- The availabe cursor names are:
--
--@DOC_cursor_c_lua_COMMON@
--
-- @property handle_cursor
-- @tparam[opt="fleur"] string|nil handle_cursor
-- @propbeautiful
Expand Down Expand Up @@ -228,7 +232,10 @@ local slider = {mt={}}
-- @tparam[opt=gears.shape.rectangle] gears.shape shape
-- @see gears.shape

--- The handle grab cursor.
--- The cursor icon while grabbing the handle.
-- The availabe cursor names are:
actionless marked this conversation as resolved.
Show resolved Hide resolved
--
--@DOC_cursor_c_lua_COMMON@
--
-- @beautiful beautiful.slider_handle_cursor
-- @tparam[opt="fleur"] string cursor
Expand Down Expand Up @@ -565,7 +572,9 @@ end
-- @tparam[opt] number args.handle_width The slider handle width.
-- @tparam[opt] color args.handle_border_color The handle border_color.
-- @tparam[opt] number args.handle_border_width The handle border width.
-- @tparam[opt] string args.handle_cursor The handle grab cursor.
-- @tparam[opt] string args.handle_cursor
-- The cursor icon while grabbing the handle.
-- The availabe cursor names are availabe in the "Object properties" section under handle_cursor
-- @tparam[opt] gears.shape args.bar_shape The bar (background) shape.
-- @tparam[opt] number args.bar_height The bar (background) height.
-- @tparam[opt] color args.bar_color The bar (background) color.
Expand Down