-
Notifications
You must be signed in to change notification settings - Fork 599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comment and documentation improvement #3943
Merged
Merged
Changes from 9 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
11fe48d
Added that the timer timeout is in seconds
aidinio 69cdfd3
Contrasted the differences of autostart and call_now
aidinio 378614b
Merge branch 'awesomeWM:master' into comment-improvement
aidinio ff422c1
A minor grammatical change
aidinio b58dfee
Merge branch 'awesomeWM:master' into comment-improvement
aidinio f496fe0
Spread comments in multiple lines so lines would be shorter
aidinio 875395f
Used three dashes instead of one for documentation
aidinio dc2afd5
Included available cursor names as an ldoc files, and also added
aidinio f9c3937
Merge branch 'awesomeWM:master' into comment-improvement
aidinio 4dda2c4
Fixed typo
aidinio dc69aad
Fixed formatting and file names
aidinio File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,80 @@ | ||
-- <div class='flex-list'> | ||
aidinio marked this conversation as resolved.
Show resolved
Hide resolved
|
||
-- <div>num\_glyphs</div> | ||
-- <div>arrow</div> | ||
-- <div>based\_arrow\_down</div> | ||
-- <div>based\_arrow\_up</div> | ||
-- <div>boat</div> | ||
-- <div>bogosity</div> | ||
-- <div>bottom\_left\_corner</div> | ||
-- <div>bottom\_right\_corner</div> | ||
-- <div>bottom\_side</div> | ||
-- <div>bottom\_tee</div> | ||
-- <div>box\_spiral</div> | ||
-- <div>center\_ptr</div> | ||
-- <div>circle</div> | ||
-- <div>clock</div> | ||
-- <div>coffee\_mug</div> | ||
-- <div>cross</div> | ||
-- <div>crosshair</div> | ||
-- <div>cross\_reverse</div> | ||
-- <div>cursor</div> | ||
-- <div>diamond\_cross</div> | ||
-- <div>dotbox</div> | ||
-- <div>dot</div> | ||
-- <div>double\_arrow</div> | ||
-- <div>draft\_large</div> | ||
-- <div>draft\_small</div> | ||
-- <div>draped\_box</div> | ||
-- <div>exchange</div> | ||
-- <div>fleur</div> | ||
-- <div>gobbler</div> | ||
-- <div>gumby</div> | ||
-- <div>hand</div> | ||
-- <div>hand</div> | ||
-- <div>heart</div> | ||
-- <div>icon</div> | ||
-- <div>iron\_cross</div> | ||
-- <div>leftbutton</div> | ||
-- <div>left\_ptr</div> | ||
-- <div>left\_side</div> | ||
-- <div>left\_tee</div> | ||
-- <div>ll\_angle</div> | ||
-- <div>lr\_angle</div> | ||
-- <div>man</div> | ||
-- <div>middlebutton</div> | ||
-- <div>mouse</div> | ||
-- <div>pencil</div> | ||
-- <div>pirate</div> | ||
-- <div>plus</div> | ||
-- <div>question\_arrow</div> | ||
-- <div>rightbutton</div> | ||
-- <div>right\_ptr</div> | ||
-- <div>right\_side</div> | ||
-- <div>right\_tee</div> | ||
-- <div>rtl\_logo</div> | ||
-- <div>sailboat</div> | ||
-- <div>sb\_down\_arrow</div> | ||
-- <div>sb\_h\_double\_arrow</div> | ||
-- <div>sb\_left\_arrow</div> | ||
-- <div>sb\_right\_arrow</div> | ||
-- <div>sb\_up\_arrow</div> | ||
-- <div>sb\_v\_double\_arrow</div> | ||
-- <div>shuttle</div> | ||
-- <div>sizing</div> | ||
-- <div>spider</div> | ||
-- <div>spraycan</div> | ||
-- <div>star</div> | ||
-- <div>target</div> | ||
-- <div>tcross</div> | ||
-- <div>top\_left\_arrow</div> | ||
-- <div>top\_left\_corner</div> | ||
-- <div>top\_right\_corner</div> | ||
-- <div>top\_side</div> | ||
-- <div>top\_tee</div> | ||
-- <div>trek</div> | ||
-- <div>ul\_angle</div> | ||
-- <div>umbrella</div> | ||
-- <div>ur\_angle</div> | ||
-- <div>watch</div> | ||
-- <div>xterm</div> | ||
-- </div> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file should be named
cursor.ldoc
. the_c
is to indicate the comments syntax is C style instead of Lua.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, should the files
/docs/common/client_theme.ldoc
and/docs/common/cobject.ldoc
have the_c
suffix too?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair point. Let's just ignore my comment then because making these filenames more consistent is out of the scope of this PR 🤷
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah you did the change for this file anyway. Nice 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I might open another PR for changing those file names.