Remove unnecessary permissions #1112
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes the automatic population of host devices at container startup, and replaces privileged with fine(r) grained capabilities. Change-type: patch Signed-off-by: Joseph Kogut <[email protected]>
Signed-off-by: Joseph Kogut <[email protected]>
Binding the host's devtmpfs inside a container, especially in combination with `privileged: true` has a high likelyhood of tampering with host device permissions and nodes. Remove it. Change-type: patch Signed-off-by: Joseph Kogut <[email protected]>
jakogut
force-pushed
the
remove-unnecessary-permissions
branch
from
b55c71f to
5d13217
Compare
|
Passes the OS suite, but fails preloading. Marking as a draft again. |
auto-merge was automatically disabled
January 31, 2024 21:39
Pull request was converted to draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.