Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Barracuda filter option #444

Merged
merged 10 commits into from
Jan 26, 2024
Merged

Barracuda filter option #444

merged 10 commits into from
Jan 26, 2024

Conversation

vikibaarathi
Copy link
Contributor

Moved DSHOT section to the filter section to keep things aligned and standardised.

@vikibaarathi
Introducing barracuda tune to betaflight
8c6a4e7
@vikibaarathi
Added discussion PR link
e216783
@vikibaarathi
Updated preset to comply with guideline
7d7d285 
Switched Status to EXPERIMENTAL.
Used simplified tuning parameters instead of individual PID/Filter. Added Apply command at the end.
Removed preset profile name.
Moved RC link to the end.
Switched RC link to use generic preset.
Changed RC link to be UNCHECKED by default
@vikibaarathi
Corrected 500Hz file name
e222e5a
@vikibaarathi
Moved DSHOT section to the filter option
1947595
@vikibaarathi
cleaned up
eac90fd
@vikibaarathi
Merge branch 'master' into barracuda
26c5cd8
@vikibaarathi
Copy link
Contributor Author

I should actually move the warning into this section also right?

@limonspb
Copy link
Member

limonspb commented Jan 25, 2024 •
edited
Loading

I should actually move the warning into this section also right?

Warnings can stay where they are now. They don't work properly if moved in options, thats something i have to work on.

Please remove extra lines in the Filters option, and we good to go.
image

haslinghuis
haslinghuis previously approved these changes Jan 25, 2024
View reviewed changes
Copy link
Member

@haslinghuis haslinghuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note Dshot 600 will not enable with dshot_bidir enabled for F4 | G4 MCU's

@limonspb
Copy link
Member

Note Dshot 600 will not enable with dshot_bidir enabled for F4 | G4 MCU's

dam, really??

@limonspb
Copy link
Member

limonspb commented Jan 26, 2024 •
edited
Loading

Note Dshot 600 will not enable with dshot_bidir enabled for F4 | G4 MCU's

ok i just tested, it goes to dshot 300 when i set it to 600 on F405.
So i guess trying to set it to 600 is not a problem? It will just go to 300 after saving (in 4.5)

@limonspb
Copy link
Member

I should actually move the warning into this section also right?

sorry there is one empty line left there in the option lol

Ivan Efimov and others added 2 commits January 26, 2024 06:40
@limonspb limonspb merged commit ad46a9f into betaflight:master Jan 26, 2024
1 check passed
@vikibaarathi
Copy link
Contributor Author

THank you for helping me clean up @limonspb. I'll check better on the next one.

@limonspb
Copy link
Member

THank you for helping me clean up @limonspb. I'll check better on the next one.

no worries Sir

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haslinghuis haslinghuis haslinghuis left review comments

@limonspb limonspb limonspb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vikibaarathi @limonspb @haslinghuis