Improve report functionality #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajdapretnar
force-pushed
the
remove-report
branch
2 times, most recently
from
a1ffa8e to
a262cfc
Compare
3 tasks
ajdapretnar
force-pushed
the
remove-report
branch
2 times, most recently
from
a1ffa8e to
76252ad
Compare
ajdapretnar
force-pushed
the
remove-report
branch
from
76252ad to
803033a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #350.
Description of changes
Remove redundant report buttons as we now have footer report.
Add report functions where they don't yet exist.
Add main calls for testing widgets.
Remaining problems
Don't know how to add word cloud to report. report_plot doesn't work as there is no tag in the constructed html. report_raw works, but places the word cloud over existing text and remains selectable.
Don't know how to make the header of Word Enrichment bold. 🤦♂️
Don't know how to shorten QTableView in Concordance to show only, say, top 50 results. I read about QSortFilterProxyModel, but I don't know how to set the number of rows.
Includes