Ben changes #266
Merged
Ben changes #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrDeshaies
commented
Jun 4, 2020
| <ul v-for="(str, index) in data.value" :key="index"> | ||
| <li>{{ getItemLabel(str, index) }}</li> | ||
| </ul> | ||
| <div v-for="(str, index) in data.value" :key="index"> |
There was a problem hiding this comment.
Aligns this component with MultiChoiceValueResult. Fixes the bug, and gives a consistent look and code.
MrDeshaies
commented
Jun 4, 2020
| "proceduralFairnessImplementation15": "There is a process in place to log instances when overrides were performed.", | ||
| "proceduralFairnessImplementation16": "The system's audit trail includes change control processes to record modifications to the system's operation or performance.", | ||
| "proceduralFairnessImplementation17": "A concept case has been prepared and approved by the Government of Canada Enterprise Architecture Review Board.", | ||
| "fairnessImplementation1": "The audit trail clearly identifies the authority or delegated authority as identified in legislation.", |
There was a problem hiding this comment.
Fix the key names, and align with survey-en-fr.json, where the order was different.
MrDeshaies
commented
Jun 4, 2020
| @@ -1104,7 +1104,7 @@ | |||
| { | |||
| "value": "item5", | |||
| "text": { | |||
| "default": "Process optimization & workflow automation: Analyzing large data sets to identify and anomalies, cluster patterns, predict outcomes or ways to optimize; and automate specific workflows", | |||
There was a problem hiding this comment.
The only ampersand in the entire file. Caused one problem (fixed through code), but using "and" seems safer and may prevent future issues.
ShadeWyrm
approved these changes
Jun 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #263
Fixes #264
Fixes #265