Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ben changes #266

Merged
merged 4 commits into from
Jun 8, 2020
Merged

Ben changes #266

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2ab1166
fix issue #264
MrDeshaies Jun 3, 2020
e0dfe4b
increment version
MrDeshaies Jun 3, 2020
7fb1b2f
fix issue #263
MrDeshaies Jun 4, 2020
b2d82dc
change French to fix previous edit
MrDeshaies Jun 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions public/helper/wet.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,8 @@ function reloadTemplate(){

var defPreFooter = document.getElementById("def-preFooter");
defPreFooter.outerHTML = wet.builder.preFooter({
dateModified: "2020-05-07",
versionIdentifier: "0.8.0",
dateModified: "2020-06-03",
versionIdentifier: "0.8.1",
showPostContent: false,
showShare: false
});
Expand Down
10 changes: 7 additions & 3 deletions src/components/MultiChoiceResult.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,13 @@
<strong v-if="locale == undefined">{{ data.title }}</strong>
<strong v-if="locale !== undefined">{{ data.titleData[locale] }}</strong>
<br />
<ul v-for="(str, index) in data.value" :key="index">
<li>{{ getItemLabel(str, index) }}</li>
</ul>
<div v-for="(str, index) in data.value" :key="index">
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aligns this component with MultiChoiceValueResult. Fixes the bug, and gives a consistent look and code.

<div class="row">
<div class="col-md-12 list-item">
{{ getItemLabel(str, index) }}
</div>
</div>
</div>
</div>
</div>
</template>
Expand Down
36 changes: 18 additions & 18 deletions src/plugins/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,8 @@
"fairnessDesign4": "All key decision points will be linked to relevant legislation, policies and procedures.",
"fairnessDesign5": "A log will be kept detailing all of the changes made to the model and to the system.",
"fairnessDesign6": "An audit trail that clearly sets out all of the decision points made by the system will be developed.",
"fairnessDesign8": "The audit trail could be used to generate a notification or statement of reasons for each decision it supports.",
"fairnessDesign7": "The audit trail will identify which version of the system was used for each decision it supports.",
"fairnessDesign8": "The audit trail could be used to generate a notification or statement of reasons for each decision it supports.",
"fairnessDesign9": "The audit trail will show who the authorized decision maker is.",
"fairnessDesign10": "The system will be able to produce reasons for its decisions or recommendations when required.",
"fairnessDesign11": "There will be a process in place to grant, monitor and revoke access permissions to the system.",
Expand All @@ -78,23 +78,23 @@
"dataQualityImplementation8": "A process has been developed to manage any risks of having outdated or unreliable data that could be used in the system.",
"dataQualityImplementation9": "This information is now publicly available.",
"dataQualityImplementation10": "The data used for the system has been posted on the Open Government portal.",
"proceduralFairnessImplementation1": "The audit trail clearly identifies the authority or delegated authority as identified in legislation.",
"proceduralFairnessImplementation2": "The system records all the recommendations or decisions made by the system.",
"proceduralFairnessImplementation3": "All key decision points are identifiable in the audit trail.",
"proceduralFairnessImplementation4": "All key decisions points are linked to the relevant legislation, policy or procedure.",
"proceduralFairnessImplementation5": "A change log has been developed to detail all of the changes made to the model and to the system.",
"proceduralFairnessImplementation6": "The audit trail identifies which version of the system was used for each decision.",
"proceduralFairnessImplementation7": "The system's audit trail indicates all of the decision points made by the system.",
"proceduralFairnessImplementation8": "The audit trail generated by the system can be used to generate notifications, including a statement of reason.",
"proceduralFairnessImplementation9": "The system's audit trail shows who the authorized decision-makers are.",
"proceduralFairnessImplementation10": "The system is able to produce reasons for its decision or recommendations when required.",
"proceduralFairnessImplementation11": "There is a process in place to grant, monitor, and revoke access permission to the system.",
"proceduralFairnessImplementation12": "There is a mechanism to capture feedback by users of the systems.",
"proceduralFairnessImplementation13": "There is a recourse process in place for clients that wish to challenge the decision.",
"proceduralFairnessImplementation14": "The system enables human override of system decisions.",
"proceduralFairnessImplementation15": "There is a process in place to log instances when overrides were performed.",
"proceduralFairnessImplementation16": "The system's audit trail includes change control processes to record modifications to the system's operation or performance.",
"proceduralFairnessImplementation17": "A concept case has been prepared and approved by the Government of Canada Enterprise Architecture Review Board.",
"fairnessImplementation1": "The audit trail clearly identifies the authority or delegated authority as identified in legislation.",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the key names, and align with survey-en-fr.json, where the order was different.

"fairnessImplementation2": "The system records all the recommendations or decisions made by the system.",
"fairnessImplementation3": "All key decision points are identifiable in the audit trail.",
"fairnessImplementation4": "All key decisions points are linked to the relevant legislation, policy or procedure.",
"fairnessImplementation5": "A change log has been developed to detail all of the changes made to the model and to the system.",
"fairnessImplementation6": "The system's audit trail indicates all of the decision points made by the system.",
"fairnessImplementation7": "The system's audit trail can be used to help generate a notification of the decision (including a statement of reasons or other notifications) where required.",
"fairnessImplementation8": "The audit trail identifies which version of the system was used for each decision.",
"fairnessImplementation9": "The system's audit trail shows who the authorized decision-makers are.",
"fairnessImplementation10": "The system is able to produce reasons for its decision or recommendations when required.",
"fairnessImplementation11": "There is a process in place to grant, monitor, and revoke access permission to the system.",
"fairnessImplementation12": "There is a mechanism to capture feedback by users of the systems.",
"fairnessImplementation13": "There is a recourse process in place for clients that wish to challenge the decision.",
"fairnessImplementation14": "The system enables human override of system decisions.",
"fairnessImplementation15": "There is a process in place to log instances when overrides were performed.",
"fairnessImplementation16": "The system's audit trail includes change control processes to record modifications to the system's operation or performance.",
"fairnessImplementation17": "A concept case has been prepared for the Government of Canada Enterprise Architecture Review Board.",
"privacyImplementation1": "",
"privacyImplementation2": "",
"requirements": {
Expand Down
2 changes: 1 addition & 1 deletion src/plugins/fr.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@
"fairnessImplementation14": "Le système permet à l'homme de passer outre aux décisions du système.",
"fairnessImplementation15": "Il y a un processus en place pour consigner les cas où des dérogations ont été effectuées.",
"fairnessImplementation16": "La piste de vérification du système comprend des processus de contrôle des changements pour enregistrer les modifications apportées au fonctionnement ou au rendement du système.",
"fairnessImplementation17": "Un dossier conceptuel a été préparé et approuvé par le Comité d'examen de l'architecture d'entreprise du gouvernement du Canada.",
"fairnessImplementation17": "Un dossier conceptuel a été préparé par le Comité d'examen de l'architecture d'entreprise du gouvernement du Canada.",
"privacyImplementation1": "Une évaluation des facteurs relatifs à la vie privée a été effectuée ou une EFVP existante a été révisée.",
"privacyImplementation2": "Le système a été conçu en tenant compte des principes de la protection de la vie privée par la conception.",
"IL": "NI",
Expand Down
2 changes: 1 addition & 1 deletion src/survey-enfr.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1104,7 +1104,7 @@
{
"value": "item5",
"text": {
"default": "Process optimization & workflow automation: Analyzing large data sets to identify and anomalies, cluster patterns, predict outcomes or ways to optimize; and automate specific workflows",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only ampersand in the entire file. Caused one problem (fixed through code), but using "and" seems safer and may prevent future issues.

"default": "Process optimization and workflow automation: Analyzing large data sets to identify and anomalies, cluster patterns, predict outcomes or ways to optimize; and automate specific workflows",
"fr": "Optimisation des processus et automatisation des flux de travail: Analyser de vastes jeux de connées pour déterminer et corriger les anomalies, les modèles de grappes, prévoir les résultats ou les façons d'optimiser; et d'automatiser des flux de travail spécifique."
}
},
Expand Down