Adding saml2 support #58
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @xtrusia, taking a look. |
|
@xtrusia can you please rebase your PR with main ? I have unblocked the cephadm CI tests, we should be able to get your PR merged with it. |
|
@UtkarshBhatthere thanks. I adjusted it. but it seems that still doesn't work yet? |
|
The CephadmTest passes which implies the change is OK. We still have not fixed the Rook tests yet. |
|
@xtrusia are all the commits in this PR not signed ? Github seems to be complaining about it. |
Signed-off-by: Utkarsh Bhatt <[email protected]>
Fixing below error by adding proper pkg $ ceph dashboard sso show saml2 Error EPERM: Required library not found: `python3-saml` Signed-off-by: Seyeong Kim <[email protected]>
Signed-off-by: Utkarsh Bhatt <[email protected]>
Signed-off-by: Utkarsh Bhatt <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing below error by adding proper pkg
$ ceph dashboard sso show saml2
Error EPERM: Required library not found:
python3-samlCloses #57