many: rename remainingPermissions to outstandingPermissions
#14865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Needs Documentation -auto-
olivercalder
force-pushed
the
prompting-rename-remainingPermissions
branch
from
339b2c1 to
148b7ab
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #14865 +/- ##
==========================================
+ Coverage 78.20% 78.28% +0.08%
==========================================
Files 1151 1157 +6
Lines 151396 152627 +1231
==========================================
+ Hits 118402 119491 +1089
- Misses 25662 25764 +102
- Partials 7332 7372 +40
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
olivercalder
force-pushed
the
prompting-rename-remainingPermissions
branch
from
148b7ab to
b162d39
Compare
github-actions
bot
removed
the
Needs Documentation -auto-
olivercalder
force-pushed
the
prompting-rename-remainingPermissions
branch
from
b162d39 to
248985f
Compare
Signed-off-by: Oliver Calder <[email protected]>
olivercalder
force-pushed
the
prompting-rename-remainingPermissions
branch
from
248985f to
6c9cc3f
Compare
bboozzoo
approved these changes
Dec 19, 2024
| @@ -33,12 +33,12 @@ const ( | |||
| MaxOutstandingPromptsPerUser = maxOutstandingPromptsPerUser | |||
| ) | |||
|
|
|||
| func NewPrompt(id prompting.IDType, timestamp time.Time, snap string, iface string, path string, remainingPermissions []string, availablePermissions []string, originalPermissions []string) *Prompt { | |||
| func NewPrompt(id prompting.IDType, timestamp time.Time, snap string, iface string, path string, outstandingPermissions []string, availablePermissions []string, originalPermissions []string) *Prompt { | |||
There was a problem hiding this comment.
otherwise it barely fits the screen 😄
Suggested change
| func NewPrompt(id prompting.IDType, timestamp time.Time, snap string, iface string, path string, outstandingPermissions []string, availablePermissions []string, originalPermissions []string) *Prompt { | |
| func NewPrompt( | |
| id prompting.IDType, timestamp time.Time, snap, iface, path string, | |
| outstandingPermissions, availablePermissions, originalPermissions []string, | |
| ) *Prompt { |
| @@ -435,7 +435,7 @@ var timeAfterFunc = func(d time.Duration, f func()) timeutil.Timer { | |||
| // | |||
| // The caller must ensure that the given permissions are in the order in which | |||
| // they appear in the available permissions list for the given interface. | |||
| func (pdb *PromptDB) AddOrMerge(metadata *prompting.Metadata, path string, requestedPermissions []string, remainingPermissions []string, listenerReq *listener.Request) (*Prompt, bool, error) { | |||
| func (pdb *PromptDB) AddOrMerge(metadata *prompting.Metadata, path string, requestedPermissions []string, outstandingPermissions []string, listenerReq *listener.Request) (*Prompt, bool, error) { | |||
There was a problem hiding this comment.
Suggested change
| func (pdb *PromptDB) AddOrMerge(metadata *prompting.Metadata, path string, requestedPermissions []string, outstandingPermissions []string, listenerReq *listener.Request) (*Prompt, bool, error) { | |
| func (pdb *PromptDB) AddOrMerge( | |
| metadata *prompting.Metadata, path string, | |
| requestedPermissions []string, outstandingPermissions []string, listenerReq *listener.Request, | |
| ) (*Prompt, bool, error) { |
|
Test failures:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename
remainingPermissionstooutstandingPermissionsand clarify their purpose and behavior in request prompts.This work is tracked internally by https://warthogs.atlassian.net/browse/SNAPDENG-30515