Skip to content
This repository has been archived by the owner on Sep 23, 2024. It is now read-only.

Add function for expanding full paths to files/directories #126

Merged
merged 2 commits into from
May 14, 2018
Merged

Add function for expanding full paths to files/directories #126

merged 2 commits into from
May 14, 2018

Conversation

major
Copy link
Contributor

@major major commented May 14, 2018 •
edited
Loading

This PR does two things:

  • Adds a simply function for getting the full path to files/directories
  • Adds tests for the new full_path() function

This is a partial fix for #94.

@major major added the enhancement New feature or request label May 14, 2018
@major major self-assigned this May 14, 2018
@major major force-pushed the expand-paths-early branch from e3b0de6 to 5cc5b8f Compare May 14, 2018 14:54
@coveralls
Copy link

coveralls commented May 14, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 423

  • 16 of 16 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+3.2%) to 47.136%
Totals Coverage Status
Change from base Build 415: 3.2%
Covered Lines: 683
Relevant Lines: 1449
💛 - Coveralls

@major major force-pushed the expand-paths-early branch from 5cc5b8f to 5568e3c Compare May 14, 2018 14:56
@major major requested a review from veruu May 14, 2018 15:10
@major major force-pushed the expand-paths-early branch from 5568e3c to 356bbdc Compare May 14, 2018 15:23
@major major changed the title Expand paths earlier Expand workdir paths earlier May 14, 2018
@major major force-pushed the expand-paths-early branch 3 times, most recently from 16e12d5 to c81aad5 Compare May 14, 2018 15:39
@major major changed the title Expand workdir paths earlier Add function for expanding full paths to files/directories May 14, 2018
@major major mentioned this pull request May 14, 2018
Merged
1 task
@major major force-pushed the expand-paths-early branch from c81aad5 to 107504c Compare May 14, 2018 15:43
veruu
veruu suggested changes May 14, 2018
View reviewed changes
Copy link
Contributor

@veruu veruu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality-wise LGTM, but can you please again adjust the wording in both commit messages? Eg "provide a function for X" instead of "this function does X"

@major major mentioned this pull request May 14, 2018
Merged
2 tasks
@major major force-pushed the expand-paths-early branch from 107504c to a63328b Compare May 14, 2018 16:33
major added 2 commits May 14, 2018 11:40
@major
Add full_path()
28fa8cd 
Signed-off-by: Major Hayden <[email protected]>
@major
Add tests for full_path() function
ce72dd3 
Signed-off-by: Major Hayden <[email protected]>
@major major force-pushed the expand-paths-early branch from a63328b to ce72dd3 Compare May 14, 2018 16:40
@veruu veruu merged commit b5b55c5 into cki-project:master May 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@veruu veruu veruu approved these changes

Assignees

@major major

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@major @coveralls @veruu