Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openssl: add embed-bitcode if tools.apple:enable_bitcode is set #14580

Closed
wants to merge 6 commits into from

Conversation

kletoz
Copy link
Contributor

@kletoz kletoz commented Dec 5, 2022

Specify library name and version: openssl/1.x.x and openssl/3.x.x.

Add -fembed-bitcode to CFLAGS if tools.apple:enable_bitcode is configured; only for iOS and tvOS.


@ghost
Copy link

ghost commented Dec 5, 2022

I detected other pull requests that are modifying openssl/1.x.x recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@Nekto89
Copy link
Contributor

Nekto89 commented Dec 5, 2022

Doesn't watchOS also use this flag?

@kletoz
Copy link
Contributor Author

kletoz commented Dec 5, 2022

Doesn't watchOS also use this flag?

Yes, it does. I'm not testing for watchOS, but as watchOS also uses this flag I will add it in the same case. Thanks!

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@kletoz
Copy link
Contributor Author

kletoz commented Jan 17, 2023

@SpaceIm, @prince-chrismc could you please recheck this PR. It's adding bitcode for Apple builds.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline

Failure in build 7 (7fdfb428d36827505d53cde89a93a2a52bcc7928):

  • openssl/1.1.1s@:
    Didn't run or was cancelled before finishing

  • openssl/1.1.1q@:
    command 'git merge --no-ff 8ef97f6' failed with exit code 1:
    Auto-merging recipes/openssl/1.x.x/conanfile.py
    CONFLICT (content): Merge conflict in recipes/openssl/1.x.x/conanfile.py
    Automatic merge failed; fix conflicts and then commit the result.

  • openssl/1.1.0l@:
    Didn't run or was cancelled before finishing

  • openssl/1.1.1p@:
    Didn't run or was cancelled before finishing

  • openssl/3.0.5@:
    Didn't run or was cancelled before finishing

  • openssl/1.0.2u@:
    Didn't run or was cancelled before finishing

  • openssl/3.0.7@:
    Didn't run or was cancelled before finishing

  • openssl/3.0.4@:
    Didn't run or was cancelled before finishing


Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants