openssl: Make debug build renaming optional

[Sil3ntStorm]

Specify library name and version: openssl/>=1.1.0

Make debug build library renaming optional for openssl >= 1.1.0 which for some inexplicable reason was explicitly added despite it not being there in upstream.

It's especially useless in a conan environment as every build has its own directory and actually makes it extremely painful to work with such libraries.

• I've read the guidelines for contributing.
• I've followed the PEP8 style guides for Python code in the recipes.
• I've used the latest Conan client version.
• I've tried at least one configuration locally with the conan-center hook activated.

[SpaceIm]

It comes from an old commit: conan-community/conan-openssl@e565e05

/cc @SSE4

Anyway this debug_suffix option has no effect for many compilers and openssl versions, so it should be deleted in these cases.

[Sil3ntStorm]

Anyway this debug_suffix option has no effect for many compilers and openssl versions, so it should be deleted in these cases.

It is already deleted for versions where it is not used. Deleting it for other compilers, will make it more complicated to use the option, as conan will complain about the option not existing when you simply specify that as an option in a consumer conanfile.

One would have to replicate the checks, or could possibly check if the option exists before setting it. In any case it would require a configure function, rather than just being able to use default_options

[SSE4]

well, it came from the bug in the FindOpenSSL.cmake in some old(er) cmake version from ~3 years ago.
maybe it's already fixed in latest release and no longer an issue? I think it's worth checking.
if so, I guess the workaround could be removed altogether, without adding a new option.
UPD: I think the right issue is https://gitlab.kitware.com/cmake/cmake/-/issues/17604

[Sil3ntStorm]

I don't really care either way, was just trying to go for "as little impact as required" which in this instance is basically no impact for those who continue to want to run it the way it has been.

Ultimately I don't care much about how this is solved, so long as it is (and continues to be with future updates) possible to have output files that are named exactly the same regardless of configuration.

Unless I missed something it seems like conan provides its own FindOpenSSL.cmake file anyway that is then used by cmake?

Happy to do changes that help reach the goal.

[stale]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[ghost]

I detected other pull requests that are modifying openssl/1.x.x recipe:

• openssl: add embed-bitcode if tools.apple:enable_bitcode is set #14580
• OpenSSL 1.x.x Conan 2.0 compatibility #14066
• openssl: Enable valid block of options for openssl >= 1.1.0 #11725

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prsso don't hesitate to report issues/improvements there.

[Sil3ntStorm]

Any update on this?
Is there any chance of merging this?

[prince-chrismc]

There's a lot of PRs open, you can see prince-chrismc/conan-center-index-pending-review#1 to track the status of CCI

there's a few minor things out of date with the bot so the results are not perfect 🤞 we can get those fixed soon ish

[prince-chrismc]

The original behavior matches upstream and the official find module https://gitlab.kitware.com/cmake/cmake/-/blob/master/Modules/FindOpenSSL.cmake#L282

Unless I missed something it seems like conan provides its own FindOpenSSL.cmake file anyway that is then used by cmake?

If you are installing the binaries built by conan center why not just use conan to consume them? as you point the generators provide the correct targets so you should not have any problems. 🤔

[SpaceIm]

It doesn't match upstream actually.

[conan-center-bot]

All green in build 5 (e2b65ee1a8db25b563ad5930e504f402c4528fc7):

• openssl/1.1.1p@:
  All packages built successfully! (All logs)

  🔸 Informative: This recipe is not ready for Conan v2

  _{We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.
  This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.
  See the recipe migration guide to know more about the changes required.}

  ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-10939/recipes/openssl/1.x.x/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-10939/recipes/openssl/1.x.x/conanfile.py
    File "<frozen importlib._bootstrap_external>", line 728, in exec_module
    File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
    File "/home/conan/w/prod_cci_PR-10939/recipes/openssl/1.x.x/conanfile.py", line 5, in <module>
      from conans import ConanFile, AutoToolsBuildEnvironment, tools
  ImportError: cannot import name 'ConanFile' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)
  

• openssl/1.1.1q@:
  All packages built successfully! (All logs)

  🔸 Informative: This recipe is not ready for Conan v2

  _{We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.
  This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.
  See the recipe migration guide to know more about the changes required.}

  ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-10939/recipes/openssl/1.x.x/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-10939/recipes/openssl/1.x.x/conanfile.py
    File "<frozen importlib._bootstrap_external>", line 728, in exec_module
    File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
    File "/home/conan/w/prod_cci_PR-10939/recipes/openssl/1.x.x/conanfile.py", line 5, in <module>
      from conans import ConanFile, AutoToolsBuildEnvironment, tools
  ImportError: cannot import name 'ConanFile' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)
  

• openssl/1.1.0l@:
  All packages built successfully! (All logs)

  🔸 Informative: This recipe is not ready for Conan v2

  _{We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.
  This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.
  See the recipe migration guide to know more about the changes required.}

  ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-10939/recipes/openssl/1.x.x/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-10939/recipes/openssl/1.x.x/conanfile.py
    File "<frozen importlib._bootstrap_external>", line 728, in exec_module
    File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
    File "/home/conan/w/prod_cci_PR-10939/recipes/openssl/1.x.x/conanfile.py", line 5, in <module>
      from conans import ConanFile, AutoToolsBuildEnvironment, tools
  ImportError: cannot import name 'ConanFile' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)
  

• openssl/1.0.2u@:
  All packages built successfully! (All logs)

  🔸 Informative: This recipe is not ready for Conan v2

  _{We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.
  This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.
  See the recipe migration guide to know more about the changes required.}

  ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-10939/recipes/openssl/1.x.x/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-10939/recipes/openssl/1.x.x/conanfile.py
    File "<frozen importlib._bootstrap_external>", line 728, in exec_module
    File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
    File "/home/conan/w/prod_cci_PR-10939/recipes/openssl/1.x.x/conanfile.py", line 5, in <module>
      from conans import ConanFile, AutoToolsBuildEnvironment, tools
  ImportError: cannot import name 'ConanFile' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)
  

• openssl/1.1.1o@:
  All packages built successfully! (All logs)

  🔸 Informative: This recipe is not ready for Conan v2

  _{We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.
  This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.
  See the recipe migration guide to know more about the changes required.}

  ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-10939/recipes/openssl/1.x.x/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-10939/recipes/openssl/1.x.x/conanfile.py
    File "<frozen importlib._bootstrap_external>", line 728, in exec_module
    File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
    File "/home/conan/w/prod_cci_PR-10939/recipes/openssl/1.x.x/conanfile.py", line 5, in <module>
      from conans import ConanFile, AutoToolsBuildEnvironment, tools
  ImportError: cannot import name 'ConanFile' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)
  

[danimtb]

there are some conflicts as notified by github

[danimtb]

This branch has conflicts that must be resolved

[stale]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[stale]

This pull request has been automatically closed because it has not had recent activity. Thank you for your contributions.