Update to python 3.12 #603

hmaarrfk · 2024-06-22T16:27:42Z

Closes #598
Closes #604

Checklist

Used a personal fork of the feedstock to propose changes
Bumped the build number (if the version is unchanged)
Reset the build number to 0 (if the version changed)
Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
Ensured the license file is being packaged.

Signed-off-by: Marcel Bargull <[email protected]>

mbargull · 2024-06-23T09:48:56Z

README.md

-| Windows | x86_64                | [Miniforge3-Windows-x86_64](https://github.com/conda-forge/miniforge/releases/latest/download/Miniforge3-Windows-x86_64.exe) |
+| OS      | Architecture                  | Minimum Version  | Download  |
+| --------|-------------------------------|------------------|-----------|
+| Linux   | x86_64 (amd64)                | glibc >= 2.12    | [Miniforge3-Linux-x86_64](https://github.com/conda-forge/miniforge/releases/latest/download/Miniforge3-Linux-x86_64.sh) |


Instead, we can just go with 2.17 here, right?! We'll drop 2.12 in a week

I just went with 2.17 -- otherwise, I'd expect this to get outdated quickly.

mbargull · 2024-06-23T09:50:01Z

README.md

+| Linux   | ppc64le (POWER8/9)            | glibc >= 2.17    | [Miniforge3-Linux-ppc64le](https://github.com/conda-forge/miniforge/releases/latest/download/Miniforge3-Linux-ppc64le.sh) |
+| OS X    | x86_64                        | macOS >= 10.13   | [Miniforge3-MacOSX-x86_64](https://github.com/conda-forge/miniforge/releases/latest/download/Miniforge3-MacOSX-x86_64.sh) |
+| OS X    | arm64 (Apple Silicon) `(***)` | macOS >= 11.0    | [Miniforge3-MacOSX-arm64](https://github.com/conda-forge/miniforge/releases/latest/download/Miniforge3-MacOSX-arm64.sh) |
+| Windows | x86_64                        | Windows >= 7     | [Miniforge3-Windows-x86_64](https://github.com/conda-forge/miniforge/releases/latest/download/Miniforge3-Windows-x86_64.exe) |


@isuruf, do you know if this is still accurate or do we have things that bump this to 10?

Signed-off-by: Marcel Bargull <[email protected]>

mbargull · 2024-06-23T10:17:38Z

Let's get some approvals from folks that can confirm that #598 (comment) is satisfied and merge/build this at the beginning/middle of the week to not cause downstream troubles over weekends.

hmaarrfk · 2024-06-23T10:37:18Z

I would like to document the last known working version:

OSX 10.9
Linux Glibc 2.12

mbargull · 2024-06-24T20:54:40Z

scripts/build.sh

+elif [[ "${TARGET_PLATFORM}" == linux-* ]]; then
+    export CONDA_OVERRIDE_OSX=10.9


Suggested change

elif [[ "${TARGET_PLATFORM}" == linux-* ]]; then

export CONDA_OVERRIDE_OSX=10.9

elif [[ "${TARGET_PLATFORM}" == osx-64 ]]; then

export CONDA_OVERRIDE_OSX=10.9

elif [[ "${TARGET_PLATFORM}" == osx-arm64 ]]; then

export CONDA_OVERRIDE_OSX=11.0

I'm fine with that change.
I generally makes sense to but the overrides in.
As for 10.9 concretely, I've also thought about doing that but didn't consider it too be of relevance -- what's the reasoning for going with that still (in light that we changed the default nearly 2 months ago)?

It was to see if this propagated. Apparently not.

if this does nothing, should we remove it entirely?

It does work; there was just a typo in the initial commit (linux-* instead of osx-*).
Even makes the PyPy builds fail -- haven't looked into why yet.

conda=24.1.1 onward has dep pypy3.9 >=7.3.15 and that one has been built against 10.13 already.
So, we need target 10.13 for that one.

refs:
https://github.com/conda-forge/pypy3.6-feedstock/pull/116/files#diff-92d4214334555338c6e098e1462e4dec3ca2032a9f2973bf5558d6b8c00503ceR2

scripts/build.sh

PyPy builds of conda>=24.1.1 depend on pypy3.9>=7.3.15 with the latter targeting macOS>=10.13.

scripts/build.sh

Co-authored-by: Isuru Fernando <[email protected]>

hmaarrfk · 2024-07-02T13:25:33Z

I can't approve my own merge request, but looks good to me!

xhochy

LGTM

jaimergp · 2024-07-24T08:28:55Z

Anything blocking the merge here? Should we just proceed?

jaimergp · 2024-07-24T08:29:57Z

README.md

+| Linux   | aarch64 (arm64) `(**)`        | glibc >= 2.17    | [Miniforge3-Linux-aarch64](https://github.com/conda-forge/miniforge/releases/latest/download/Miniforge3-Linux-aarch64.sh) |
+| Linux   | ppc64le (POWER8/9)            | glibc >= 2.17    | [Miniforge3-Linux-ppc64le](https://github.com/conda-forge/miniforge/releases/latest/download/Miniforge3-Linux-ppc64le.sh) |
+| OS X    | x86_64                        | macOS >= 10.13   | [Miniforge3-MacOSX-x86_64](https://github.com/conda-forge/miniforge/releases/latest/download/Miniforge3-MacOSX-x86_64.sh) |
+| OS X    | arm64 (Apple Silicon) `(***)` | macOS >= 11.0    | [Miniforge3-MacOSX-arm64](https://github.com/conda-forge/miniforge/releases/latest/download/Miniforge3-MacOSX-arm64.sh) |


Do we still need that footnote?

(***) Apple silicon builds are experimental and haven't had testing like the other platforms.

We don't have CI for macOS ARM

That said, maybe we can relax this note a bit

I'm not opposed to this, but I think a new PR is warranted if we want to review the language around OSX + arm.

Lets start the builds for this as they take a while already.

EwoutH · 2024-08-03T20:11:08Z

Thanks for this! When can we expect a new release which includes this PR?

hmaarrfk · 2024-08-03T21:16:59Z

We are blocked on

#614

you can for your CI purposes just create a new test environment with python 3.12. It will only cost about 100MB of downloads.

Update to python 3.12

bddad0b

hmaarrfk force-pushed the update_python_version_202406 branch from 3bceb51 to bddad0b Compare June 22, 2024 16:33

hmaarrfk mentioned this pull request Jun 23, 2024

Update to python 3.11 #604

Closed

5 tasks

hmaarrfk marked this pull request as ready for review June 23, 2024 01:51

hmaarrfk requested a review from a team as a code owner June 23, 2024 01:51

hmaarrfk mentioned this pull request Jun 23, 2024

Vote to update to 3.11 or 3.12 - Ends June 23 #598

Closed

Update included Python version in README.md

5c7d713

Signed-off-by: Marcel Bargull <[email protected]>

mbargull reviewed Jun 23, 2024

View reviewed changes

mbargull added 3 commits June 23, 2024 11:52

Add minimum OS versions to table

d2f7b3c

Signed-off-by: Marcel Bargull <[email protected]>

Include Ubuntu 24.04 in tests

3446c80

Signed-off-by: Marcel Bargull <[email protected]>

Update Debian versions in tests

eabae5e

Signed-off-by: Marcel Bargull <[email protected]>

mbargull force-pushed the update_python_version_202406 branch from 00b8307 to eabae5e Compare June 23, 2024 09:53

hmaarrfk and others added 3 commits June 23, 2024 07:21

Add a note about older OSX and glibc

e6d1ade

Update micromamba to 1.5.8

c76e542

Set virtual pacakges before solve

c946576

mbargull reviewed Jun 24, 2024

View reviewed changes

Set virtual packages before solve

9b05448

mbargull reviewed Jun 25, 2024

View reviewed changes

scripts/build.sh Outdated Show resolved Hide resolved

Update macOS target to 10.13

27b7266

PyPy builds of conda>=24.1.1 depend on pypy3.9>=7.3.15 with the latter targeting macOS>=10.13.

isuruf reviewed Jun 25, 2024

View reviewed changes

scripts/build.sh Outdated Show resolved Hide resolved

Increase GLIBC requirement to 2.17

d5b7ca9

Co-authored-by: Isuru Fernando <[email protected]>

xhochy approved these changes Jul 5, 2024

View reviewed changes

jaimergp linked an issue Jul 16, 2024 that may be closed by this pull request

Moving base environment to 3.12? #597

Closed

jaimergp mentioned this pull request Jul 17, 2024

Where can I download Python 3.12 base environment？？ #611

Closed

dlaehnemann mentioned this pull request Jul 18, 2024

azure CI Run docker build step for win and linux fails: python version mismatch during Configure conda conda-forge/staged-recipes#27024

Closed

jaimergp reviewed Jul 24, 2024

View reviewed changes

jaimergp linked an issue Jul 24, 2024 that may be closed by this pull request

Where can I download Python 3.12 base environment？？ #611

Closed

hmaarrfk merged commit cd78df0 into conda-forge:main Jul 24, 2024
24 checks passed

EwoutH mentioned this pull request Aug 3, 2024

test CI: Update Conda jobs to Python 3.12 Toblerity/Fiona#1422

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update to python 3.12 #603

Update to python 3.12 #603

hmaarrfk commented Jun 22, 2024 •

edited

Loading

mbargull Jun 23, 2024 •

edited

Loading

mbargull Jun 23, 2024

mbargull Jun 23, 2024 •

edited

Loading

mbargull commented Jun 23, 2024

hmaarrfk commented Jun 23, 2024

mbargull Jun 24, 2024 •

edited

Loading

isuruf Jun 25, 2024

hmaarrfk Jun 25, 2024

mbargull Jun 25, 2024

mbargull Jun 25, 2024

hmaarrfk commented Jul 2, 2024

xhochy left a comment

jaimergp commented Jul 24, 2024

jaimergp Jul 24, 2024

jaimergp Jul 24, 2024

jakirkham Jul 24, 2024

hmaarrfk Jul 24, 2024

EwoutH commented Aug 3, 2024

hmaarrfk commented Aug 3, 2024

		elif [[ "${TARGET_PLATFORM}" == linux-* ]]; then
		export CONDA_OVERRIDE_OSX=10.9

	\| OS X \| arm64 (Apple Silicon) `(***)` \| macOS >= 11.0 \| [Miniforge3-MacOSX-arm64](https://github.com/conda-forge/miniforge/releases/latest/download/Miniforge3-MacOSX-arm64.sh) \|
	\| OS X \| arm64 (Apple Silicon) \| macOS >= 11.0 \| [Miniforge3-MacOSX-arm64](https://github.com/conda-forge/miniforge/releases/latest/download/Miniforge3-MacOSX-arm64.sh) \|

Update to python 3.12 #603

Update to python 3.12 #603

Conversation

hmaarrfk commented Jun 22, 2024 • edited Loading

mbargull Jun 23, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mbargull Jun 23, 2024 • edited Loading

Choose a reason for hiding this comment

mbargull commented Jun 23, 2024

hmaarrfk commented Jun 23, 2024

mbargull Jun 24, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hmaarrfk commented Jul 2, 2024

xhochy left a comment

Choose a reason for hiding this comment

jaimergp commented Jul 24, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

EwoutH commented Aug 3, 2024

hmaarrfk commented Aug 3, 2024

hmaarrfk commented Jun 22, 2024 •

edited

Loading

mbargull Jun 23, 2024 •

edited

Loading

mbargull Jun 23, 2024 •

edited

Loading

mbargull Jun 24, 2024 •

edited

Loading