CORE-17437: State Manager Configuration Section #1277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jenkins build for PR 1277 build 11 Build Successful: |
jujoramos
force-pushed
the
feature/CORE-17437
branch
2 times, most recently
from
9acb330 to
b27e8c9
Compare
|
Related runtime-os change: corda/corda-runtime-os#4780 |
...a/src/main/resources/net/corda/schema/configuration/stateManager/1.0/corda.stateManager.json
Outdated
Show resolved
Hide resolved
...n/resources/net/corda/schema/configuration/stateManager/1.0/state-manager-db-properties.json
Outdated
Show resolved
Hide resolved
data/db-schema/src/main/resources/net/corda/db/schema/state-manager/db.changelog-master.xml
Outdated
Show resolved
Hide resolved
data/config-schema/src/main/java/net/corda/schema/configuration/StateManagerConfig.java
Show resolved
Hide resolved
data/config-schema/src/main/java/net/corda/schema/configuration/StateManagerConfig.java
Outdated
Show resolved
Hide resolved
data/config-schema/src/main/java/net/corda/schema/configuration/MessagingConfig.java
Show resolved
Hide resolved
jujoramos
force-pushed
the
feature/CORE-17437
branch
from
b27e8c9 to
adeb932
Compare
|
|
||
| // Database Configuration Values | ||
| public static final class Database { | ||
| public static final String DB_PROPERTIES = "database"; |
There was a problem hiding this comment.
Yeah that's better, so when users pass config to the stateManagerFactory.create() the configs don't need to be in a "stateManager" level 👍 (i.e. user can listen for changes to "ConfigKeys.STATE_MANAGER_CONFIG" key, and on this change, pass the config at config.getConfig(ConfigKeys.STATE_MANAGER_CONFIG)
There was a problem hiding this comment.
Promote State Manager configuration to its own section and remove it from under the Messaging configuration.
jujoramos
force-pushed
the
feature/CORE-17437
branch
from
47d4362 to
e3dc655
Compare
JamesHR3
approved these changes
Oct 9, 2023
mbrkic-r3
approved these changes
Oct 9, 2023
jujoramos
added a commit
to jujoramos/corda-api
that referenced
this pull request
Oct 10, 2023
This reverts commit edc6b36.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Promote State Manager configuration to its own section and remove it
from under the Messaging configuration.