CORE-17437: State Manager Configuration Section #4780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jujoramos
force-pushed
the
feature/CORE-17437
branch
2 times, most recently
from
0c1b4df to
3a630c9
Compare
|
Jenkins build for PR 4780 build 19 Build Successful: |
jujoramos
force-pushed
the
feature/CORE-17437
branch
from
892835a to
55c4c1c
Compare
|
Related api change: corda/corda-api#1277 |
...cation/application-db-setup/src/main/kotlin/net/corda/application/dbsetup/PostgresDbSetup.kt
Outdated
Show resolved
Hide resolved
...ion/configuration-merger/src/main/kotlin/net/corda/libs/configuration/merger/ConfigMerger.kt
Show resolved
Hide resolved
...n/src/main/kotlin/net/corda/libs/configuration/validation/impl/ConfigurationValidatorImpl.kt
Show resolved
Hide resolved
.../src/test/kotlin/net/corda/applications/workers/workercommon/internal/BootstrapConfigTest.kt
Show resolved
Hide resolved
jujoramos
force-pushed
the
feature/CORE-17437
branch
from
1d58468 to
658d7c6
Compare
JamesHR3
previously approved these changes
Oct 9, 2023
mbrkic-r3
previously approved these changes
Oct 9, 2023
Promote State Manager configuration to its own section and remove it from under the Messaging configuration.
jujoramos
force-pushed
the
feature/CORE-17437
branch
from
bb8cb67 to
78d7fa8
Compare
JamesHR3
previously approved these changes
Oct 9, 2023
conalsmith-r3
previously approved these changes
Oct 9, 2023
mbrkic-r3
previously approved these changes
Oct 9, 2023
simon-johnson-r3
previously approved these changes
Oct 9, 2023
driessamyn
suggested changes
Oct 9, 2023
| @@ -40,17 +40,14 @@ class FlowMaintenanceImpl @Activate constructor( | |||
| private var stateManager: StateManager? = null | |||
|
|
|||
| override fun onConfigChange(config: Map<String, SmartConfig>) { | |||
| // TODO - fix config key (CORE-17437). | |||
| if(config.containsKey(ConfigKeys.MESSAGING_CONFIG)) { | |||
| if (config.containsKey(ConfigKeys.STATE_MANAGER_CONFIG)) { | |||
There was a problem hiding this comment.
I don't think this is correct as this assumes that the messaging config is always already there when the state manager config arrives.
I think they need to be treated separate.
jujoramos
dismissed stale reviews from simon-johnson-r3, mbrkic-r3, conalsmith-r3, and JamesHR3
via
15779ce
JamesHR3
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Promote State Manager configuration to its own section and remove it
from under the Messaging configuration.