-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CORE-15813: Add VirtualNodeUpdateRequest/VirtualNodeUpdateResponse #1345
Merged
josephzunigadaly
merged 4 commits into
release/os/5.2
from
jzd/CORE-15813-REST-Connection-string-update
Dec 1, 2023
Merged
CORE-15813: Add VirtualNodeUpdateRequest/VirtualNodeUpdateResponse #1345
josephzunigadaly
merged 4 commits into
release/os/5.2
from
jzd/CORE-15813-REST-Connection-string-update
Dec 1, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scanning for breaking API changes introduced by this PR Scan Succeeded |
Jenkins build for PR 1345 build 10 Build Successful: |
josephzunigadaly
force-pushed
the
jzd/CORE-15813-REST-Connection-string-update
branch
3 times, most recently
from
November 23, 2023 13:41
221332a
to
90ae854
Compare
josephzunigadaly
force-pushed
the
jzd/CORE-15813-REST-Connection-string-update
branch
3 times, most recently
from
November 28, 2023 16:32
359fd0e
to
643bb67
Compare
josephzunigadaly
force-pushed
the
jzd/CORE-15813-REST-Connection-string-update
branch
from
November 29, 2023 10:51
643bb67
to
94e2549
Compare
vkolomeyko
reviewed
Nov 30, 2023
...chema/src/main/resources/avro/net/corda/data/virtualnode/VirtualNodeAsynchronousRequest.avsc
Outdated
Show resolved
Hide resolved
...vro-schema/src/main/resources/avro/net/corda/data/virtualnode/VirtualNodeUpdateResponse.avsc
Outdated
Show resolved
Hide resolved
Co-authored-by: Viktor Kolomeyko <[email protected]>
Co-authored-by: Viktor Kolomeyko <[email protected]>
Kudos, SonarCloud Quality Gate passed! |
vkolomeyko
approved these changes
Dec 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
josephzunigadaly
deleted the
jzd/CORE-15813-REST-Connection-string-update
branch
December 1, 2023 12:50
josephzunigadaly
added a commit
to corda/corda-runtime-os
that referenced
this pull request
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These types support a new REST endpoint for vnode connection string update.
corda/corda-runtime-os#5121