Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORE-15813: Add VirtualNodeUpdateRequest/VirtualNodeUpdateResponse #1345

Merged

Conversation

josephzunigadaly
Copy link
Contributor

@josephzunigadaly josephzunigadaly commented Nov 16, 2023

These types support a new REST endpoint for vnode connection string update.

corda/corda-runtime-os#5121

@josephzunigadaly josephzunigadaly self-assigned this Nov 16, 2023
@josephzunigadaly josephzunigadaly marked this pull request as draft November 16, 2023 16:25
@corda-jenkins-ci02
Copy link
Contributor

Scanning for breaking API changes introduced by this PR

Scan Succeeded

@corda-jenkins-ci02
Copy link
Contributor

corda-jenkins-ci02 bot commented Nov 16, 2023

Jenkins build for PR 1345 build 10

Build Successful:
Jar artifact version produced by this PR: 5.2.0.10-alpha-1701359223339

@josephzunigadaly josephzunigadaly force-pushed the jzd/CORE-15813-REST-Connection-string-update branch 3 times, most recently from 221332a to 90ae854 Compare November 23, 2023 13:41
@josephzunigadaly josephzunigadaly force-pushed the jzd/CORE-15813-REST-Connection-string-update branch 3 times, most recently from 359fd0e to 643bb67 Compare November 28, 2023 16:32
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@vkolomeyko vkolomeyko self-requested a review December 1, 2023 12:20
Copy link
Contributor

@vkolomeyko vkolomeyko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josephzunigadaly josephzunigadaly merged commit 5c01c3c into release/os/5.2 Dec 1, 2023
7 checks passed
@josephzunigadaly josephzunigadaly deleted the jzd/CORE-15813-REST-Connection-string-update branch December 1, 2023 12:50
josephzunigadaly added a commit to corda/corda-runtime-os that referenced this pull request Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants