Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORE-15813: Add REST endpoint for vnode connection string update #5121

Merged

Conversation

josephzunigadaly
Copy link
Contributor

@josephzunigadaly josephzunigadaly commented Nov 16, 2023

@josephzunigadaly josephzunigadaly self-assigned this Nov 16, 2023
@josephzunigadaly josephzunigadaly force-pushed the jzd/CORE-15813-REST-Connection-string-update branch 9 times, most recently from 4bb55fc to d201b86 Compare November 23, 2023 13:44
@josephzunigadaly josephzunigadaly force-pushed the jzd/CORE-15813-REST-Connection-string-update branch 15 times, most recently from 5ddd839 to 95a0a98 Compare November 29, 2023 13:54
@corda-jenkins-ci02
Copy link
Contributor

corda-jenkins-ci02 bot commented Nov 29, 2023

Jenkins build for PR 5121 build 44

Build Successful:
Jar artifact version produced by this PR: 5.2.0.0-alpha-1701448580078
Helm chart version produced by this PR: 5.2.0-alpha.1701448580078
Helm chart pushed to: oci://corda-os-docker-dev.software.r3.com/helm-charts/pr-5121/corda

gradle.properties Outdated Show resolved Hide resolved
@josephzunigadaly josephzunigadaly force-pushed the jzd/CORE-15813-REST-Connection-string-update branch from d4338b8 to 0688af5 Compare November 29, 2023 15:16
@josephzunigadaly josephzunigadaly marked this pull request as ready for review November 30, 2023 14:31
@josephzunigadaly josephzunigadaly force-pushed the jzd/CORE-15813-REST-Connection-string-update branch from 0688af5 to f4f016b Compare November 30, 2023 15:46
@vkolomeyko vkolomeyko requested a review from a team November 30, 2023 15:55
@josephzunigadaly josephzunigadaly force-pushed the jzd/CORE-15813-REST-Connection-string-update branch from 38d9499 to 60bb0f1 Compare December 1, 2023 10:20
@vkolomeyko vkolomeyko self-requested a review December 1, 2023 12:20
josephzunigadaly added a commit to corda/corda-api that referenced this pull request Dec 1, 2023
…1345)

These types support a new REST endpoint for vnode connection string update.

corda/corda-runtime-os#5121
vkolomeyko
vkolomeyko previously approved these changes Dec 1, 2023
Copy link
Contributor

@vkolomeyko vkolomeyko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

sonarqubecloud bot commented Dec 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vkolomeyko vkolomeyko self-requested a review December 1, 2023 17:25
Copy link
Contributor

@vkolomeyko vkolomeyko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josephzunigadaly josephzunigadaly merged commit b33034b into release/os/5.2 Dec 4, 2023
6 checks passed
@josephzunigadaly josephzunigadaly deleted the jzd/CORE-15813-REST-Connection-string-update branch December 4, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants