Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement: Move BYD startup messages to 10s block #751

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dalathegreat
Copy link
Owner

What

This PR adds a delay on the initial data sending we do on the BYD CAN protocol

Why

Instead of sending the messages the first 1ms after CPU starts up, we wait 10 seconds until we fire this batch send.

How

In theory this should help some startup race conditions observed by users

@GoSmartEV
Copy link

10 seconds is too short, as the battery in a Volvo, for example, only starts after 10 seconds. Then the inverter takes about 10-20 seconds to begin sending data over the CAN. Please increase this time to 60 seconds.

@dalathegreat
Copy link
Owner Author

@GoSmartEV , changed to 60 seconds in commit b81e0f5

@GoSmartEV
Copy link

@GoSmartEV , changed to 60 seconds in commit b81e0f5

It doesn’t recognize it in the right way the battery and invertor

IMG_5791
IMG_5792

@dalathegreat
Copy link
Owner Author

Hmm, not really sure how to solve this. If this PR did not help anything, I suggest we close it as wont do for now, and investigate your startup issue more in detail

@GoSmartEV
Copy link

GoSmartEV commented Jan 5, 2025

Hmm, not really sure how to solve this. If this PR did not help anything, I suggest we close it as wont do for now, and investigate your startup issue more in detail

the program does not correctly determine where the battery and where the inverter is

But the CAN message are at the correct

this problem was in the oldest firmware too, it feels like it’s just mixed up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants