Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix path of patch_ssm() for pytest fixutre #772

Merged
merged 1 commit into from
Sep 28, 2023

Conversation

noah-paige
Copy link
Contributor

Feature or Bugfix

  • Bugfix

Detail

  • Fix path to parameter utils for local pytest
    • Originally local make coverage erroring out of patch_ssm() due to non-existing attribute dataall.base.utils.parameter.Parameter.get_parameter

Relates

  • NA

Security

Please answer the questions below briefly where applicable, or write N/A. Based on
OWASP 10.

NA

- Does this PR introduce or modify any input fields or queries - this includes
fetching data from storage outside the application (e.g. a database, an S3 bucket)?
  - Is the input sanitized?
  - What precautions are you taking before deserializing the data you consume?
  - Is injection prevented by parametrizing queries?
  - Have you ensured no `eval` or similar functions are used?
- Does this PR introduce any functionality or component that requires authorization?
  - How have you ensured it respects the existing AuthN/AuthZ mechanisms?
  - Are you logging failed auth attempts?
- Are you using or adding any cryptographic features?
  - Do you use a standard proven implementations?
  - Are the used keys controlled by the customer? Where are they stored?
- Are you introducing any new policies/roles/users?
  - Have you used the least-privilege principle? How?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@noah-paige noah-paige requested a review from dlpzx September 19, 2023 20:19
@noah-paige
Copy link
Contributor Author

Tested for local make coverage and for AWS Deployment IntegrationTests CodeBuild - both successful

@noah-paige noah-paige self-assigned this Sep 22, 2023
@noah-paige noah-paige merged commit 38a089d into main Sep 28, 2023
@dlpzx dlpzx deleted the fix/pytest-get-parameter branch November 8, 2023 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants