Fix Migration Script for New Deployment

[noah-paige]

Feature or Bugfix

• Bugfix

Detail

• When deploying from scratch - the migration script for byo vpc for mlstudio had a line of code if has_table('sagemaker_studio_domain') which was evaluating to False and skipping necessary migration code

  • Removed the if has_table() and just throw Exception in try/catch block for upgrade migration script

• Also as part of this PR I made sure the security group gets created in the mlstudio_extension stack no matter what type of VPC we use for ML Studio Domain

  • Without the Security Group VpcOnly Deployments of ML Studio Domain with security_group=[] will never be able to connect to internet without manual changes
  • Tested with Imported VPC and provisioned Studio User Profile - can access internet via NAT Gateway as prescribed with VPCOnly deployments if internet access is required
  • Tested changes to ML Studio Domain Security Group does NOT cause new creation of Domain (only UpdateDomain no replacement) --> Environment Stack Updates Successfully

Relates

• Byo vpc mlstudio #894

Security

N/A
Please answer the questions below briefly where applicable, or write N/A. Based on
OWASP 10.

• Does this PR introduce or modify any input fields or queries - this includes
  fetching data from storage outside the application (e.g. a database, an S3 bucket)?
  • Is the input sanitized?
  • What precautions are you taking before deserializing the data you consume?
  • Is injection prevented by parametrizing queries?
  • Have you ensured no eval or similar functions are used?
• Does this PR introduce any functionality or component that requires authorization?
  • How have you ensured it respects the existing AuthN/AuthZ mechanisms?
  • Are you logging failed auth attempts?
• Are you using or adding any cryptographic features?
  • Do you use a standard proven implementations?
  • Are the used keys controlled by the customer? Where are they stored?
• Are you introducing any new policies/roles/users?
  • Have you used the least-privilege principle? How?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[dlpzx]

Looks good and tested!