[OING-340] feature: 가족 초대 딥링크 발급 로직 변경 및 가족 초대 뷰 기반 API 실제 로직 추가 #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 52 files 52 suites 12s ⏱️ Results for commit b942375. ♻️ This comment has been updated with latest results. |
Code Coverage
|
Ji-soo708
commented
Jun 17, 2024
|
|
||
| @Override | ||
| public FamilyInviteDeepLinkResponse getFamilyInviteLinkDetails(String linkId, String loginMemberId) { | ||
|
|
||
| // TODO : 기능 구현할 때, 응답 모킹용 코드 삭제하고 아래 주석 풀기 | ||
| boolean isRequesterJoinedFamily = false; | ||
| // MemberResponse me = meApi.getMe(loginMemberId); |
There was a problem hiding this comment.
meApi의 getMe 메서드를 그대로 사용하면 로그인하지 않은 사용자가 해당 API를 호출할 때, Member를 찾을 수 없다는 예외가 터져 해당 API용 getMemberNullable를 따로 추가해서 처리했습니다.
|
Ji-soo708
commented
Jun 18, 2024
| .from(member) | ||
| .where(member.familyId.eq(familyId) | ||
| .and(member.deletedAt.isNull())) | ||
| .orderBy(member.profileImgUrl.desc().nullsLast()) |
There was a problem hiding this comment.
기획 상으로는 프로필 이미지가 존재하는 회원부터 대표 구성원으로 보여야한다고 해서 정렬했습니다
CChuYong
pushed a commit
that referenced
this pull request
Jun 21, 2024
* feature: add column to deep_link tbl and family_invite_link tbl * feature: modify logic for issuing deep links * feature: add inviter information logic to view-based API * feature: add family name column to family tbl * test: add family constructor to familyName field in test * feature: add countSurvivalPostsByFamilyId method * feature: add getFamilyMember's info method * feature: add getFamilyMember's info logic to getFamilyInviteLinkDetails method * feature: add getFamilyMemberNames logic * chore: add delete previous data from deep_link and family_invite_link tbl * test: add MemberRepositoryCustomTest
Ji-soo708
added a commit
that referenced
this pull request
Jun 21, 2024
* feature: add column to deep_link tbl and family_invite_link tbl * feature: modify logic for issuing deep links * feature: add inviter information logic to view-based API * feature: add family name column to family tbl * test: add family constructor to familyName field in test * feature: add countSurvivalPostsByFamilyId method * feature: add getFamilyMember's info method * feature: add getFamilyMember's info logic to getFamilyInviteLinkDetails method * feature: add getFamilyMemberNames logic * chore: add delete previous data from deep_link and family_invite_link tbl * test: add MemberRepositoryCustomTest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❓ 기능 추가 배경
가족 초대 딥링크 발급 로직 변경 및 가족 초대 뷰 기반 API 실제 로직 추가했습니다.
➕ 추가/변경된 기능
🥺 리뷰어에게 하고싶은 말
추가된 코드가 많아 커밋 별로 보시면 편합니다.
🔗 참조 or 관련된 이슈
https://no5ing.atlassian.net/browse/OING-340