-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OING-340] feature: 가족 초대 딥링크 발급 로직 변경 및 가족 초대 뷰 기반 API 실제 로직 추가 #262
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
642dbfe
feature: add column to deep_link tbl and family_invite_link tbl
Ji-soo708 7cd1a56
feature: modify logic for issuing deep links
Ji-soo708 54c30cb
feature: add inviter information logic to view-based API
Ji-soo708 269fa64
feature: add family name column to family tbl
Ji-soo708 0d44f71
test: add family constructor to familyName field in test
Ji-soo708 8e25dfa
feature: add countSurvivalPostsByFamilyId method
Ji-soo708 227fb26
feature: add getFamilyMember's info method
Ji-soo708 cf1aa26
feature: add getFamilyMember's info logic to getFamilyInviteLinkDetai…
Ji-soo708 d5f5129
feature: add getFamilyMemberNames logic
Ji-soo708 5d6ff75
chore: add delete previous data from deep_link and family_invite_link…
Ji-soo708 b942375
test: add MemberRepositoryCustomTest
Ji-soo708 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
package com.oing.service; | ||
|
||
public interface FamilyBridge { | ||
String findFamilyNameByFamilyId(String familyId); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 changes: 19 additions & 0 deletions
19
gateway/src/main/java/com/oing/service/FamilyBridgeImpl.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
package com.oing.service; | ||
|
||
import com.oing.domain.Family; | ||
import com.oing.repository.FamilyRepository; | ||
import lombok.RequiredArgsConstructor; | ||
import org.springframework.stereotype.Service; | ||
|
||
@RequiredArgsConstructor | ||
@Service | ||
public class FamilyBridgeImpl implements FamilyBridge { | ||
private final FamilyRepository familyRepository; | ||
|
||
@Override | ||
public String findFamilyNameByFamilyId(String familyId) { | ||
return familyRepository.findById(familyId) | ||
.map(Family::getFamilyName) | ||
.orElse(null); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 changes: 8 additions & 0 deletions
8
...ources/db/migration/V202406171820__add_column_to_deep_link_and_family_invite_link_tbl.sql
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
ALTER TABLE `deep_link` ADD COLUMN (`member_id` CHAR(26) COMMENT 'ULID'); | ||
ALTER TABLE `deep_link` ADD COLUMN (`family_id` CHAR(26) COMMENT 'ULID'); | ||
ALTER TABLE `family_invite_link` ADD COLUMN (`member_id` CHAR(26) COMMENT 'ULID'); | ||
DELETE FROM `deep_link` WHERE `family_id` IS NULL OR `member_id` IS NULL; | ||
DELETE FROM `family_invite_link` WHERE `member_id` IS NULL; | ||
ALTER TABLE `deep_link` MODIFY COLUMN `member_id` CHAR(26) NOT NULL; | ||
ALTER TABLE `deep_link` MODIFY COLUMN `family_id` CHAR(26) NOT NULL; | ||
ALTER TABLE `family_invite_link` MODIFY COLUMN `member_id` CHAR(26) NOT NULL; |
1 change: 1 addition & 0 deletions
1
...y/src/main/resources/db/migration/V202406171920__add_family_name_column_to_family_tbl.sql
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
ALTER TABLE `family` ADD COLUMN (`family_name` CHAR(10)); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
meApi의
getMe
메서드를 그대로 사용하면 로그인하지 않은 사용자가 해당 API를 호출할 때, Member를 찾을 수 없다는 예외가 터져 해당 API용getMemberNullable
를 따로 추가해서 처리했습니다.