fix: bump rasterio and correctly reproject ukcp18 2.2km #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j08lue
approved these changes
Sep 10, 2024
There was a problem hiding this comment.
I ran the notebook and then converted the resulting Zarr (Xarray version) to GeoTIFF for checking in QGIS with
import xarray as xr
import rioxarray
import zarr
store = zarr.DirectoryStore("./src/test/test_output/hazard/hazard.zarr/chronic_heat/osc/v2/days_tas_above_15c_ukcp18_rcp85_2030_xarray")
ds = xr.open_dataset(store, engine="zarr")
ds.rio.to_raster("days_tas_above_15c_ukcp18_rcp85_2030.tif")and can confirm that the output is correctly georeferenced.
ciaransweet
added a commit
that referenced
this pull request
Sep 10, 2024
* fix: bump rasterio and correctly reproject ukcp18 2.2km * feat: bump cwl image * Fix env var name and use pathlib --------- Co-authored-by: j08lue <[email protected]> Signed-off-by: Ciaran Sweet <[email protected]>
ciaransweet
added a commit
that referenced
this pull request
Nov 4, 2024
…mate#124) * fix: bump rasterio and correctly reproject ukcp18 2.2km * feat: bump cwl image * Fix env var name and use pathlib --------- Signed-off-by: Ciaran Sweet <[email protected]> Co-authored-by: j08lue <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR is
Thanks to @j08lue and his rasterio magic abilities, this PR implements a fix which correctly handles rotated pole coordinates for the UKCP18 2.2km data
It bumps
rasterioto>=1.4b1so as to be able to use thesrc_geoloc_arrayparameter inrasterio.warp.reprojectHow you can test it
I've updated the notebook to show examples of all resolution/domain variants and the results saved in the notebook are a 2.2km run
However you can also see the correct alignment here:
Screen.Recording.2024-09-09.at.09.58.42.mov