fix: Make capture mode return enrollments in capture scope [TECH-1635] #15518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #15518 +/- ##
============================================
+ Coverage 66.21% 66.23% +0.02%
- Complexity 31216 31246 +30
============================================
Files 3485 3485
Lines 129739 129766 +27
Branches 15134 15142 +8
============================================
+ Hits 85905 85952 +47
+ Misses 36749 36735 -14
+ Partials 7085 7079 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 25 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
enricocolasante
requested changes
Oct 27, 2023
| @@ -204,6 +206,9 @@ public List<Enrollment> getEnrollments(EnrollmentOperationParams params) | |||
| && queryParams.isOrganisationUnitMode(OrganisationUnitSelectionMode.ACCESSIBLE)) { | |||
| queryParams.setOrganisationUnits(user.getTeiSearchOrganisationUnitsWithFallback()); | |||
| queryParams.setOrganisationUnitMode(OrganisationUnitSelectionMode.DESCENDANTS); | |||
| } else if (user != null && queryParams.isOrganisationUnitMode(CAPTURE)) { | |||
There was a problem hiding this comment.
We should apply the same fix to the next method that gets a Page of enrollments
enricocolasante
approved these changes
Oct 27, 2023
…ments' into TECH-1635-capture-mode-in-enrollments
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Capture mode in /enrollments returns enrollments in search scope, which should not happen.
With this fix, we return only enrollments in the user capture scope.