bake: various fixes for composable attributes #2814
Conversation
jsternberg
force-pushed
the
bake-composable-attributes-phase2
branch
from
72a566c to
73f055d
Compare
jsternberg
force-pushed
the
bake-composable-attributes-phase2
branch
from
73f055d to
70c1cad
Compare
jsternberg
force-pushed
the
bake-composable-attributes-phase2
branch
2 times, most recently
from
8eafb54 to
753705d
Compare
jsternberg
force-pushed
the
bake-composable-attributes-phase2
branch
2 times, most recently
from
d03e42f to
4e32acc
Compare
jsternberg
changed the title
jsternberg
force-pushed
the
bake-composable-attributes-phase2
branch
from
4e32acc to
91f0596
Compare
jsternberg
force-pushed
the
bake-composable-attributes-phase2
branch
2 times, most recently
from
e86f8b3 to
e466b5b
Compare
crazy-max
force-pushed
the
bake-composable-attributes-phase2
branch
from
e466b5b to
d0212a9
Compare
|
rebased to fix xx issue |
| Equal(other E) bool | ||
| } | ||
|
|
||
| func removeDupes[E comparable[E]](s []E) []E { |
There was a problem hiding this comment.
This seems to be duplicated. Additionally (not for this PR) there is also removeDupesStr but it uses map. I think this could also avoid N^2 complexity but not sure if worth it as the inputs are likely small.
There was a problem hiding this comment.
The purpose of this was it could utilize the Equal method that was added so it wasn't so dependent on strings. Due to the small number of inputs, the N^2 complexity isn't likely to be an issue. This might actually be faster than removeDupesStr just because maps have some issues when used for deduplicating small inputs due to overhead from memory allocation and hash key lookups.
This was duplicated and I've removed the duplicate from bake/bake.go. When I originally did this, it was in bake/bake.go and then I started moving stuff. It was easier to just copy it at the time. Since I missed the change to call Normalize() for t.SSH as pointed out in the other comment, the linter didn't catch that the original call was no longer needed since all calls had been moved to this file. I've changed that to use Normalize() and removed the duplicate.
jsternberg
force-pushed
the
bake-composable-attributes-phase2
branch
3 times, most recently
from
bb1f448 to
15d291c
Compare
This changes how the composable attributes are implemented and provides various fixes to the first iteration. Cache-from and cache-to now no longer print sensitive values that are automatically added. These automatically added attributes are added when the protobuf is created rather than at the time of parsing so they will no longer be printed. If they are part of the original configuration file, they will still be printed. Empty strings will now be skipped. This was the original behavior and composable attributes removed this functionality accidentally. This functionality is now restored. This also expands the available syntax that works with each of the composable attributes. It is now possible to interleave the csv syntax with the object syntax without any problems. The canonical form is still the object syntax and variables are resolved according to that syntax. Signed-off-by: Jonathan A. Sternberg <[email protected]>
jsternberg
force-pushed
the
bake-composable-attributes-phase2
branch
from
15d291c to
5dd4ae0
Compare
This changes how the composable attributes are implemented and provides
various fixes to the first iteration.
Cache-from and cache-to now no longer print sensitive values that are
automatically added. These automatically added attributes are added when
the protobuf is created rather than at the time of parsing so they will
no longer be printed. If they are part of the original configuration
file, they will still be printed.
Empty strings will now be skipped. This was the original behavior and
composable attributes removed this functionality accidentally. This
functionality is now restored.
This also expands the available syntax that works with each of the
composable attributes. It is now possible to interleave the csv syntax
with the object syntax without any problems. The canonical form is still
the object syntax and variables are resolved according to that syntax.
Fixes #2823.
Fixes #2822.
Fixes #2858
Replaces #2832.
Replaces #2833.