Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InclusiveKinematicseSigma -> InclusiveKinematicsESigma #1572

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Aug 16, 2024

This helps to highlight a difference to electron $\Sigma$ method vs $\Sigma$ method to avoid confusion (there were questions on mattermost).

@veprbl veprbl requested a review from wdconinc August 16, 2024 15:42
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
33.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Copy link
Contributor

@wdconinc wdconinc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with me :-)

Related, if we ever have ePIC in a CamelCase context, will it become EPIC? ;-)

@wdconinc
Copy link
Contributor

SonarCloud doesn't make it easy to find where the duplication is, https://sonarcloud.io/code?id=eic_EICrecon&pullRequest=1572&selected=eic_EICrecon%3Asrc%2Falgorithms%2Freco%2FInclusiveKinematicsESigma.cc ...

It's not wrong but it is also out of scope here. At some point we should create an InclusiveKinematics base class that does the common first part.

@wdconinc wdconinc added this pull request to the merge queue Aug 16, 2024
Merged via the queue into main with commit 4a2e46e Aug 16, 2024
85 of 87 checks passed
@wdconinc wdconinc deleted the pr/whats-e-matter branch August 16, 2024 18:57
github-merge-queue bot pushed a commit that referenced this pull request Aug 24, 2024
#1577)

Provide a graceful deprecation for
#1572

---------

Co-authored-by: Wouter Deconinck <[email protected]>
@veprbl veprbl added this to the 24.09.0 milestone Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants