Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi auth provider credentials #93

Merged
merged 20 commits into from
Jan 2, 2025
Merged

Conversation

kdp-cloud
Copy link
Collaborator

@kdp-cloud kdp-cloud commented Nov 21, 2024

  • Changes the authentication to incorporate multiple sets of credentials, which are repository specific.
  • Makes the file-transfer protocol mandatory

@kdp-cloud kdp-cloud marked this pull request as ready for review November 21, 2024 16:19
@bedroesb bedroesb linked an issue Nov 23, 2024 that may be closed by this pull request
mars-cli/mars_lib/submit.py Outdated Show resolved Hide resolved
mars-cli/mars_lib/authentication.py Show resolved Hide resolved
@kdp-cloud
Copy link
Collaborator Author

Test towards BioSamples and ENA:

############# Welcome to the MARS CLI. #############
Running in Development environment
Starting submission of the ISA JSON to the target repositories: biosamples, ena.
ISA JSON with investigation 'Bob's investigation' is valid.
Submission to biosamples was successful. Result:
{'targetRepository': 'biosamples', 'errors': [], 'info': [], 'accessions': [{'value': 'SAMEA131504475', 'path': [{'key': 'investigation'}, {'key': 'studies', 'where': {'key': 'title', 'value': 'Arabidopsis thaliana'}}, {'key': 'materials'}, {'key': 'samples', 'where': {'key': 'name', 'value': 'leaf 1'}}]}, {'value': 'SAMEA131504474', 'path': [{'key': 'investigation'}, {'key': 'studies', 'where': {'key': 'title', 'value': 'Arabidopsis thaliana'}}, {'key': 'materials'}, {'key': 'sources', 'where': {'key': 'name', 'value': 'plant 1'}}]}]}
#sample/331: comments=[] id='#ontology_annotation/accession_#sample/331' annotationValue='SAMEA131504475' termAccession=None termSource=None.
#source/330: comments=[] id='#ontology_annotation/accession_#source/330' annotationValue='SAMEA131504474' termAccession=None termSource=None.
ENA_TEST2.R2.fastq.gz already exists and has the same size on the FTP, skipping
Start submitting to ena.
Submission to ena was successful. Result:
{'targetRepository': 'ena', 'errors': [], 'info': [{'message': 'This submission is a TEST submission and will be discarded within 24 hours'}], 'accessions': [{'value': 'ERP167451', 'path': [{'key': 'investigation'}, {'key': 'studies', 'where': {'key': 'title', 'value': 'Arabidopsis thaliana'}}]}, {'value': 'ERX13505762', 'path': [{'key': 'investigation'}, {'key': 'studies', 'where': {'key': 'title', 'value': 'Arabidopsis thaliana'}}, {'key': 'assays', 'where': {'key': '@id', 'value': '#assay/18_20_21'}}, {'key': 'materials'}, {'key': 'otherMaterials', 'where': {'key': '@id', 'value': '#other_material/332'}}]}, {'value': 'ERX13505763', 'path': [{'key': 'investigation'}, {'key': 'studies', 'where': {'key': 'title', 'value': 'Arabidopsis thaliana'}}, {'key': 'assays', 'where': {'key': '@id', 'value': '#assay/18_20_21'}}, {'key': 'materials'}, {'key': 'otherMaterials', 'where': {'key': '@id', 'value': '#other_material/333'}}]}]}
Update ISA-JSON based on receipt from ena.
#other_material/332: comments=[] id='#ontology_annotation/accession_#other_material/332' annotationValue='ERX13505762' termAccession=None termSource=None.
#other_material/333: comments=[] id='#ontology_annotation/accession_#other_material/333' annotationValue='ERX13505763' termAccession=None termSource=None.

@kdp-cloud kdp-cloud requested a review from bedroesb January 2, 2025 11:17
@kdp-cloud kdp-cloud force-pushed the multi-auth-provider-credentials branch from 51c6a09 to de21fb6 Compare January 2, 2025 14:28
@bedroesb
Copy link
Member

bedroesb commented Jan 2, 2025

We get pie!
image
🥳

@bedroesb
Copy link
Member

bedroesb commented Jan 2, 2025

I managed to do a successful submission to ENA, but a failed submission to ENA would still print it as successful. Don't know if we want to fix that in this PR

@kdp-cloud
Copy link
Collaborator Author

I managed to do a successful submission to ENA, but a failed submission to ENA would still print it as successful. Don't know if we want to fix that in this PR

No I think this PR is old enough as it is. We can fix it later.

Copy link
Member

@bedroesb bedroesb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@kdp-cloud kdp-cloud merged commit 8ee3540 into main Jan 2, 2025
8 checks passed
kdp-cloud added a commit that referenced this pull request Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make password file support multiple password pairs
3 participants