Make ClientConfiguration Configurable! #30
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -65,7 +60,9 @@ | |||
| @ConfigDefault("null") | |||
| public Optional<String> getAccessKeyId(); | |||
|
|
|||
| // TODO timeout, ssl, etc | |||
There was a problem hiding this comment.
This p-r meets the requirements of this TODO?
|
(If you have a good class name for |
| import java.security.SecureRandom; | ||
|
|
||
| /** | ||
| * Created by takahiro.nakayama on 3/25/16. |
There was a problem hiding this comment.
please don't add this line
There was a problem hiding this comment.
Ok, I remove this from next time.
|
I commented. I created #31. |
|
This p-r was merged to #31, so close this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @frsyuki @muga
I wrote
ClientConfigurationConfiguableclass, which make it possible to be configuredClientConfigurationby users' config.yml.(Because I want to change the
maxErrorRetryparameter.)So, how do you think?
NOTE:
RetryPolicyandDnsResolveris interface, so they cannot be configured by the yaml.