Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Duration unit to use sec, msec, usec, and min suffix in params #31

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Added Duration unit to use sec, msec, usec, and min suffix in params #31

wants to merge 6 commits into from

Conversation

frsyuki
Copy link
Contributor

@frsyuki frsyuki commented Apr 12, 2016

This pull-request follows up #30.

  • this change adds Duration class to get duration parameters so that we can use usec, msec, sec, min, hour and day suffix in parameter. If no suffix is set, sec is used. This is same approach with airlift and Presto.
  • simplified config code.
  • changed connection_max_idle_millis to connection_max_idle.
  • added socket_send_buffer_size_hint and socket_receive_buffer_size_hint to README.
  • added SDK default of protocol and connection_timeout to README.

@frsyuki frsyuki mentioned this pull request Apr 12, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frsyuki @civitaspo