[mob][photos] Use media_kit player for videos not supported by native player #4429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tified if video isn't playable on iOS
…ideo playback by default and toggles to use media_kit for playback when UseMediaKitForVideo event is fired
…, similar to controls of native player.
…edia_kit controls
… on ios + let the user manually switch to media kit
…tive video player
ua741
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On iOS, if a video is unsupported by the native player, the app will switch automatically to use media_kit player.
On android, user will have to manually switch to the media_kit player.
I used white with 20% opacity for the icon that switches to the MediaKit player, making it most noticeable against the darkest background (black, when the video isn't playable) and less prominent against lighter backgrounds.
Switch_to_media_kit_android.mp4
Have fixed a UI/UX issue on the video player seen when the video has a caption/description.