Install Java 8, Android command line tools and SDK for Ubuntu #188
Conversation
These are used for Envoy Mobile's CI and currently installed on every CI job run: https://github.com/envoyproxy/envoy/blob/main/mobile/ci/linux_ci_setup.sh Signed-off-by: JP Simard <[email protected]>
There was a problem hiding this comment.
im wondering if it would be possible to do this with bazel - seems like there are bazel rules - https://bazel.build/docs/android-ndk
I think Keith looked into it and ran into this issue: bazelbuild/rules_android_ndk#24 |
Signed-off-by: JP Simard <[email protected]>
jpsim
changed the title
Signed-off-by: JP Simard <[email protected]>
jpsim
force-pushed
the
install-android-command-line-tools-and-sdk-for-ubuntu
branch
from
c2cd427 to
0c8ec2e
Compare
| $SDKMANAGER --install "platforms;android-30" | ||
| $SDKMANAGER --install "build-tools;30.0.2" | ||
|
|
||
| export "ANDROID_HOME=${ANDROID_HOME}" |
There was a problem hiding this comment.
i think these wont be available in the container env when it is run and dont seem to be used in the build
There was a problem hiding this comment.
I’ll look into how to set env variables in Docker from a bash script then.
the intention is to have these set when the container runs.
There was a problem hiding this comment.
i think you want to set them as ENV vars in the Dockerfile and then you can use them here and at runtime
Signed-off-by: JP Simard <[email protected]>
Signed-off-by: JP Simard <[email protected]>
Signed-off-by: JP Simard <[email protected]>
jpsim
force-pushed
the
install-android-command-line-tools-and-sdk-for-ubuntu
branch
from
ef1a2b5 to
1a127b2
Compare
jpsim
deleted the
install-android-command-line-tools-and-sdk-for-ubuntu
branch
[skip ci] Install Java 8, Android command line tools and SDK for Ubuntu (#188) * Install Android command line tools and SDK for Ubuntu These are used for Envoy Mobile's CI and currently installed on every CI job run: https://github.com/envoyproxy/envoy/blob/main/mobile/ci/linux_ci_setup.sh Signed-off-by: JP Simard <[email protected]>
[skip ci] Regenerate linux toolchains from dce0a8c [skip ci] Install Java 8, Android command line tools and SDK for Ubuntu (#188) * Install Android command line tools and SDK for Ubuntu These are used for Envoy Mobile's CI and currently installed on every CI job run: https://github.com/envoyproxy/envoy/blob/main/mobile/ci/linux_ci_setup.sh Signed-off-by: JP Simard <[email protected]>
|
This grew the size of the Docker image by quite a bit: 1.79 GB to 3.77 GB That's unfortunate given the vast majority of Envoy's CI jobs don't need the Android toolchain installed. @phlax what if we added a new image that was Ubuntu+Android so that most CI jobs can use the leaner image, and the Envoy Mobile CI jobs can use this heavier one? I'm also seeing some issues even using this image on CI: envoyproxy/envoy#24460 |
that was my original concern - that is going to be a huge problem - it will slow all envoy ci down a lot (3.77 is the compressed size to in reality it will take a lot more space)
yep we already overload dockerhub and have intermittent issues
i really dont see any other way - it will take a bit to set up cc @lizan |
|
i guess its worth asking my original question again - is there no way we could do this with bazel ? |
|
I'll revert this until we sort out of a better solution.
I'd love to find a way to do this with Bazel, but I think the blocker is still here: bazelbuild/rules_android_ndk#24 |
…envoyproxy#188)" This reverts commit dce0a8c.
|
looking at the fail trying to use this - i think even if we separated out to a different image it will still have issues in github actions being too large |
…envoyproxy#188)" This reverts commit dce0a8c. Signed-off-by: JP Simard <[email protected]>
The issue isn't on the GitHub Actions side, it's on the EngFlow RBE side. It's being looked into here: https://envoyproxy.slack.com/archives/C02QMNG92A3/p1670596188932999 |
…roxy#188) * Install Android command line tools and SDK for Ubuntu These are used for Envoy Mobile's CI and currently installed on every CI job run: https://github.com/envoyproxy/envoy/blob/main/mobile/ci/linux_ci_setup.sh Signed-off-by: JP Simard <[email protected]>
These are used for Envoy Mobile's CI and currently installed on every CI job run: https://github.com/envoyproxy/envoy/blob/main/mobile/ci/linux_ci_setup.sh