Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update codespell to v2.1.0 #2406

Merged
merged 7 commits into from
Jul 5, 2022
Merged

ci: update codespell to v2.1.0 #2406

merged 7 commits into from
Jul 5, 2022

Conversation

Augustyniak
Copy link
Contributor

@Augustyniak Augustyniak commented Jul 5, 2022

Description: Update codespell to v2.1.0 due to an issue that surfaced in #2400 : /usr/local/Cellar/[email protected]/3.10.5/Frameworks/Python.framework/Versions/3.10/lib/python3.10/codecs.py:905: RuntimeWarning: line buffering (buffering=1) isn't supported in binary mode, the default buffer size will be used file = builtins.open(filename, mode, buffering). According to codespell-project/codespell#1331 the update is what fixes it.
Risk Level: Low, linting change only
Testing: N/A
Docs Changes: N/A
Release Notes: Done

Signed-off-by: Rafal Augustyniak [email protected]

Signed-off-by: Rafal Augustyniak <[email protected]>
Signed-off-by: Rafal Augustyniak <[email protected]>
@Augustyniak Augustyniak changed the title Update codespell to v1.17.1 ci: update codespell to v1.17.1 Jul 5, 2022
Signed-off-by: Rafal Augustyniak <[email protected]>
@Augustyniak Augustyniak requested a review from jpsim July 5, 2022 15:06
Signed-off-by: Rafal Augustyniak <[email protected]>
Signed-off-by: Rafal Augustyniak <[email protected]>
@Augustyniak Augustyniak changed the title ci: update codespell to v1.17.1 ci: update codespell to v2.1.0 Jul 5, 2022
Signed-off-by: Rafal Augustyniak <[email protected]>
@@ -41,6 +41,7 @@ Features:
- android: create simple persistent SharedPreferencesStore (:issue: `#2319 <2319>`)
- iOS: A documentation archive is now included in the GitHub release artifact (:issue: `#2335 <2335>`)
- api: improved C++ APIs compatibility with Java / Kotlin / Swift (:issue `#2362 <2362>`)
- ci: bump codespell version to v2.1.0 (:issue `#2406 <2406>`)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We usually only include user-facing changes in the changelog.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

Signed-off-by: Rafal Augustyniak <[email protected]>
@Augustyniak Augustyniak requested a review from jpsim July 5, 2022 15:21
@Augustyniak Augustyniak enabled auto-merge (squash) July 5, 2022 15:22
@Augustyniak Augustyniak merged commit 5c4de98 into main Jul 5, 2022
@Augustyniak Augustyniak deleted the update-codespell branch July 5, 2022 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants