api: make Headers and HeadersBuilder case-insensitive #2400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rafal Augustyniak <[email protected]>
Signed-off-by: Rafal Augustyniak <[email protected]>
Signed-off-by: Rafal Augustyniak <[email protected]>
Signed-off-by: Rafal Augustyniak <[email protected]>
Signed-off-by: Rafal Augustyniak <[email protected]>
Signed-off-by: Rafal Augustyniak <[email protected]>
|
Blocked by #2406 |
Signed-off-by: Rafal Augustyniak <[email protected]>
Signed-off-by: Rafal Augustyniak <[email protected]>
Augustyniak
added a commit
that referenced
this pull request
Jul 5, 2022
Description: Update codespell to v2.1.0 due to an issue that surfaced in #2400 : `/usr/local/Cellar/[email protected]/3.10.5/Frameworks/Python.framework/Versions/3.10/lib/python3.10/codecs.py:905: RuntimeWarning: line buffering (buffering=1) isn't supported in binary mode, the default buffer size will be used file = builtins.open(filename, mode, buffering)`. According to codespell-project/codespell#1331 the update is what fixes it. Risk Level: Low, linting change only Testing: N/A Docs Changes: N/A Release Notes: Done Signed-off-by: Rafal Augustyniak <[email protected]>
…sensitive Signed-off-by: Rafal Augustyniak <[email protected]>
Signed-off-by: Rafal Augustyniak <[email protected]>
Signed-off-by: Rafal Augustyniak <[email protected]>
Signed-off-by: Rafal Augustyniak <[email protected]>
Signed-off-by: Rafal Augustyniak <[email protected]>
Signed-off-by: Rafal Augustyniak <[email protected]>
Signed-off-by: Rafal Augustyniak <[email protected]>
Signed-off-by: Rafal Augustyniak <[email protected]>
Signed-off-by: Rafal Augustyniak <[email protected]>
Signed-off-by: Rafal Augustyniak <[email protected]>
Signed-off-by: Rafal Augustyniak <[email protected]>
Signed-off-by: Rafal Augustyniak <[email protected]>
Signed-off-by: Rafal Augustyniak <[email protected]>
Signed-off-by: Rafal Augustyniak <[email protected]>
Signed-off-by: Rafal Augustyniak <[email protected]>
Signed-off-by: Rafal Augustyniak <[email protected]>
jpsim
reviewed
Jul 6, 2022
| return this | ||
| } | ||
|
|
||
| private fun isRestrictedHeader(name: String) = name.startsWith(":") || | ||
| name.startsWith("x-envoy-mobile") || name == "host" | ||
| name.startsWith("x-envoy-mobile", ignoreCase = true) || name.equals("host", ignoreCase = true) |
There was a problem hiding this comment.
Nice, the parameter label helps a lot here.
jpsim
approved these changes
Jul 6, 2022
Augustyniak
deleted the
andr-make-headers-and-headersbuilder-case-insensitive
branch
Augustyniak
added a commit
that referenced
this pull request
Jul 6, 2022
Description: Updating version history to reflect user facing changes introduced in #2400. Risk Level: None Testing: N/A Docs Changes: N/A Release Notes: N/A Signed-off-by: Rafal Augustyniak <[email protected]>
Augustyniak
added a commit
that referenced
this pull request
Jul 7, 2022
…ors public (#2410) Description: Revert constructors' visibility to the state from before #2400. These constructors were supposed to be public. Risk Level: None Testing: None Docs Changes: N/A Release Notes: N/A Signed-off-by: Rafal Augustyniak <[email protected]>
jpsim
pushed a commit
to envoyproxy/envoy
that referenced
this pull request
Nov 29, 2022
Description: Update codespell to v2.1.0 due to an issue that surfaced in envoyproxy/envoy-mobile#2400 : `/usr/local/Cellar/[email protected]/3.10.5/Frameworks/Python.framework/Versions/3.10/lib/python3.10/codecs.py:905: RuntimeWarning: line buffering (buffering=1) isn't supported in binary mode, the default buffer size will be used file = builtins.open(filename, mode, buffering)`. According to codespell-project/codespell#1331 the update is what fixes it. Risk Level: Low, linting change only Testing: N/A Docs Changes: N/A Release Notes: Done Signed-off-by: Rafal Augustyniak <[email protected]> Signed-off-by: JP Simard <[email protected]>
jpsim
pushed a commit
to envoyproxy/envoy
that referenced
this pull request
Nov 29, 2022
Description: Updating version history to reflect user facing changes introduced in envoyproxy/envoy-mobile#2400. Risk Level: None Testing: N/A Docs Changes: N/A Release Notes: N/A Signed-off-by: Rafal Augustyniak <[email protected]> Signed-off-by: JP Simard <[email protected]>
jpsim
pushed a commit
to envoyproxy/envoy
that referenced
this pull request
Nov 29, 2022
…ors public (#2410) Description: Revert constructors' visibility to the state from before envoyproxy/envoy-mobile#2400. These constructors were supposed to be public. Risk Level: None Testing: None Docs Changes: N/A Release Notes: N/A Signed-off-by: Rafal Augustyniak <[email protected]> Signed-off-by: JP Simard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: An Android change that mimics iOS changes from #2383. Make the lookup of headers in HeadersBuilder and Headers case-insensitive and preserve the original casing of headers.
Risk Level: Low
Testing: Unit
Docs Changes: Done
Release Notes: Done
Fixes: #2390
Signed-off-by: Rafal Augustyniak [email protected]