fix(gittar): optimize ai code-review #6201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #6201 +/- ##
=======================================
Coverage 22.60% 22.61%
=======================================
Files 1830 1831 +1
Lines 195925 195940 +15
=======================================
+ Hits 44296 44309 +13
- Misses 146568 146569 +1
- Partials 5061 5062 +1
|
…uch than maxSize. The behaviour should be same as sync.WaitGroup: you can add all items just once at first.
|
/cherry-pick release/2.4-beta.5 |
erda-bot
pushed a commit
to erda-bot/erda
that referenced
this pull request
Jan 3, 2024
* limit_sync_group: fix the issue that s.Add blocked when added-items much than maxSize. The behaviour should be same as sync.WaitGroup: you can add all items just once at first. * optimize prompt and review result * replace function-call by normal chat completion * remove useless code
erda-bot
added a commit
that referenced
this pull request
Jan 3, 2024
* limit_sync_group: fix the issue that s.Add blocked when added-items much than maxSize. The behaviour should be same as sync.WaitGroup: you can add all items just once at first. * optimize prompt and review result * replace function-call by normal chat completion * remove useless code Co-authored-by: sfwn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
optimize ai code-review
Which issue(s) this PR fixes:
ChangeLog
Need cherry-pick to release versions?
Add comment like
/cherry-pick release/2.4-beta.5when this PR is merged.