Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: conditions for select registercenter instance from db #6445

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

feat: gomonkey test

ab421bf
Select commit
Loading
Failed to load commit list.
Open

fix: conditions for select registercenter instance from db #6445

feat: gomonkey test
ab421bf
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 18, 2024 in 0s

15.12% (target 10.00%)

View this Pull Request on Codecov

15.12% (target 10.00%)

Details

Codecov Report

Attention: Patch coverage is 66.66667% with 5 lines in your changes missing coverage. Please review.

Project coverage is 15.12%. Comparing base (d217119) to head (ab421bf).

Files with missing lines Patch % Lines
...l/apps/msp/resource/deploy/handlers/mysql/mysql.go 76.92% 2 Missing and 1 partial ⚠️
...nternal/tools/orchestrator/services/addon/addon.go 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6445   +/-   ##
=======================================
  Coverage   15.12%   15.12%           
=======================================
  Files        3675     3675           
  Lines      377005   377020   +15     
=======================================
+ Hits        57018    57030   +12     
- Misses     314540   314543    +3     
  Partials     5447     5447           
Files with missing lines Coverage Δ
...nternal/tools/orchestrator/services/addon/addon.go 13.55% <0.00%> (-0.01%) ⬇️
...l/apps/msp/resource/deploy/handlers/mysql/mysql.go 11.41% <76.92%> (+2.73%) ⬆️

... and 7 files with indirect coverage changes