Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EIP-7685: exclude empty requests in requests list #1046

Merged

Conversation

marioevz
Copy link
Member

@marioevz marioevz commented Dec 4, 2024

What was wrong?

The following PRs include breaking changes in the behavior of requests for devnet-5:

ethereum/execution-apis#599
ethereum/EIPs#8989

How was it fixed?

Remove requests elements from the requests list if the byte array is empty.

Also do not remove the request_type byte in the return list of the T8N result since it's now necessary to calculate the requests commitment.

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@marioevz
Copy link
Member Author

marioevz commented Dec 4, 2024

I see that the tox issue is from running our latest generated blockchain tests, which makes sense since we are altering the expected hash in the header of any Prague test, but to generate a new set of tests we need this PR.

It's an interesting dependency problem.

@SamWilsn
Copy link
Collaborator

SamWilsn commented Dec 5, 2024

Can you generate and release new tests before this is merged, or should I force merge this?

@marioevz
Copy link
Member Author

marioevz commented Dec 5, 2024

Can you generate and release new tests before this is merged, or should I force merge this?

I think our option could be to combine all required branches into a temporary forks/prague branch in some of our forks, make the release by pointing to that, then re-run CI in this PR.

@petertdavies petertdavies changed the base branch from forks/prague to devnets/prague/5 December 5, 2024 21:23
@petertdavies
Copy link
Collaborator

This has now been pointed at the devnets/prague/5 branch. Tests will be disabled in that branch until EEST generates prague-devnet-5 fixtures.

Copy link
Collaborator

@petertdavies petertdavies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@petertdavies petertdavies merged commit 34097a0 into ethereum:devnets/prague/5 Dec 6, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants