This repository has been archived by the owner on Jan 18, 2024. It is now read-only.
[config] Fix Android scandir error when ejecting on windows #2774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This doesn't fix the issue related to iOS splash screen configuration, I'm looking into that now. Edit: this is related to some issues in the |
brentvatne
reviewed
Oct 9, 2020
| } | ||
|
|
||
| function getCurrentPackageName(projectRoot: string) { | ||
| const packageRoot = getPackageRoot(projectRoot); | ||
| const mainApplicationPath = getMainApplicationPath({ projectRoot, packageRoot }); | ||
| const packagePath = path.dirname(mainApplicationPath); | ||
| const packagePathParts = packagePath.replace(packageRoot, '').split(path.sep).filter(Boolean); | ||
| const packagePathParts = path.relative(packageRoot, packagePath).split(path.sep).filter(Boolean); |
brentvatne
reviewed
Oct 9, 2020
| return mainApplications[0]; | ||
| // Also, glob always returns a posix formatted path (even on windows), | ||
| // lets normalize that so we can use it with `.split(path.sep)` | ||
| return path.normalize(mainApplications[0]); |
There was a problem hiding this comment.
@byCedric - maybe we should make a wrapper around glob that always returns a normalized path to stop this from biting us in the future
brentvatne
approved these changes
Oct 9, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2711
The issue originates (once again) from
glob. This always returns a posix formatted path, even on Windows. This messes up thepath.sepbecause that's different on Windows. I think it's a good thing to normalize paths when using glob, it changes the format of the path to the expected one on Windows.It's also good to use
path.relativemore when stripping root paths. It takes all differences into account related to windows/posix paths and just returns you the path you need.