Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added github actions support for jdwp project #68

Merged
merged 11 commits into from
Oct 23, 2023
Merged

Added github actions support for jdwp project #68

merged 11 commits into from
Oct 23, 2023

Conversation

Daquiver1
Copy link
Contributor

This PR tackles issue #55. It creates the GitHub actions workflow for the JDWP projects.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 19, 2023
michalgr
michalgr requested changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@michalgr michalgr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the final version of this pr could you rename current builds.yml to bpftools.yml and put new logic in jdwp.yml ?

.github/workflows/builds.yml Outdated Show resolved Hide resolved
.github/workflows/builds.yml Outdated Show resolved Hide resolved
.github/workflows/builds.yml Outdated Show resolved Hide resolved
.github/workflows/builds.yml Outdated Show resolved Hide resolved
@Daquiver1 Daquiver1 requested a review from michalgr October 20, 2023 16:37
@michalgr michalgr merged commit 2b8801b into facebookexperimental:main Oct 23, 2023
9 checks passed
@michalgr
Copy link
Contributor

LGTM, for the future it would be best to use git mv to rename files rather than removing them and adding back with a new name. git mv makes it easier to track the history of changes.

@Daquiver1
Copy link
Contributor Author

LGTM, for the future it would be best to use git mv to rename files rather than removing them and adding back with a new name. git mv makes it easier to track the history of changes.

Sure, will do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalgr michalgr Awaiting requested review from michalgr

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Daquiver1 @michalgr @facebook-github-bot