Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package: Win32 copy version info #754

Merged
merged 12 commits into from
Jan 11, 2024

Conversation

mokurin000
Copy link
Contributor

No description provided.

@mokurin000 mokurin000 marked this pull request as ready for review January 11, 2024 08:40
@coveralls
Copy link

coveralls commented Jan 11, 2024

Pull Request Test Coverage Report for Build 7491180175

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 55.164%

Totals Coverage Status
Change from base Build 7477815657: 0.0%
Covered Lines: 8621
Relevant Lines: 15628

💛 - Coveralls

Copy link
Member

@cosven cosven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

Comment on lines 26 to 28
run: |
fuo_version=$( echo 'print(__import__("feeluown").__version__, end="")' | python | tr -c '[:digit:]' '.')
create-version-file .\.metadata.yml --version $fuo_version
Copy link
Member

@cosven cosven Jan 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implement this in Makefile so that we can run make bundle locally.

@cosven
Copy link
Member

cosven commented Jan 11, 2024

version info 的好处:

windows这里右键fuo.exe后文件属性会有版本号和文件简介
以及modernflyout能拿到fuo的名字

Copy link
Member

@cosven cosven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cosven cosven merged commit 6f96233 into feeluown:master Jan 11, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants