Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package: Win32 copy version info #754

Merged
merged 12 commits into from
Jan 11, 2024
Merged

package: Win32 copy version info #754

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
d493558
fix(ci): install `pyinstaller-versionfile`
mokurin000 Jan 11, 2024
c0dfc4b
packaging(win): append details to windows packaged executable
mokurin000 Jan 11, 2024
4a249be
fix(ci): apply version conversion
mokurin000 Jan 11, 2024
8d948c7
package: generate version_file.txt in Makefile
mokurin000 Jan 11, 2024
bec03f3
fix(ci): package(win): fix file path
mokurin000 Jan 11, 2024
63a30e4
fix Makefile
mokurin000 Jan 11, 2024
80e40ae
fix Makefile
mokurin000 Jan 11, 2024
0d2c86f
fix: recipes and standalone
mokurin000 Jan 11, 2024
5f55dc2
fix: remove \
mokurin000 Jan 11, 2024
9992a68
fix: try `!=` in Makefile
mokurin000 Jan 11, 2024
bedc391
idk what's happening
mokurin000 Jan 11, 2024
36c08e3
fix Makefile
mokurin000 Jan 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/win-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ jobs:
python -m pip install --upgrade pip
pip install pyqt5
pip install pyinstaller
pip install pyinstaller-versionfile
pip install -e .[win32,battery]
- name: Download mpv-1.dll
run: |
Expand Down
9 changes: 9 additions & 0 deletions .metadata.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
CompanyName: FeelUOwn
FileDescription: FeelUOwn
InternalName: FeelUOwn
LegalCopyright: © FeelUOwn. All rights reserved.
OriginalFilename: FeelUOwn.exe
ProductName: FeelUOwn
Translation:
- langID: 2052
charsetID: 1200
7 changes: 7 additions & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,9 +60,16 @@ integration_test:
test: lint unittest

BUNDLE_FLAGS=

target: ;

ifeq ($(OS),Windows_NT)
BUNDLE_FLAGS += --name FeelUOwn
BUNDLE_FLAGS += --icon feeluown/gui/assets/icons/feeluown.ico
BUNDLE_FLAGS += --version-file version_file.txt
target:
create-version-file .metadata.yml --version \
$(shell python -c 'print(__import__("feeluown").__version__, end="")' | tr -c '[:digit:]' '.')
else
# macOS: since apfs is not case-sensitive, we use FeelUOwnX instead of FeelUOwn
BUNDLE_FLAGS += --name FeelUOwnX --osx-bundle-identifier org.feeluown.FeelUOwnX
Expand Down
Loading