Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

documentation running locally #389

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

documentation running locally #389

wants to merge 1 commit into from

Conversation

PanderMusubi
Copy link
Contributor

No description provided.

@PanderMusubi PanderMusubi mentioned this pull request Apr 30, 2024
Merged
justanwar
justanwar requested changes May 1, 2024
View reviewed changes
Copy link
Member

@justanwar justanwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Needs to be in code block, otherwise rendered as one long line

erciccione
erciccione suggested changes May 2, 2024
View reviewed changes
Copy link
Contributor

@erciccione erciccione left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is necessary. We point to Jekyll's documentation in the readme, where people can find specific instructions for their platforms. These instructions might be confusing

@PanderMusubi
Copy link
Contributor Author

If you have already gems installed, the upstream instructions are not sufficient. I can add some context, what is for Ubuntu, what is generic, e.g.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justanwar justanwar justanwar requested changes

@erciccione erciccione erciccione requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PanderMusubi @erciccione @justanwar