test: Depend on a recent enough version of libportal #1527
Conversation
|
Would be nice to have the "why?" answered in the commit message and not just in a github comment. |
| @@ -120,7 +120,7 @@ geoclue_dep = dependency( | |||
| ) | |||
| libportal_dep = dependency( | |||
| 'libportal', | |||
| version: '>= 0.8.1', | |||
| version: '>= 0.9.0', | |||
There was a problem hiding this comment.
libportal 0.9.0 has not been released yet. If x-d-p needs a newer libportal than 0.8.1, then we need a libportal release first.
There was a problem hiding this comment.
the thing is:
- it's only for the test
- it used to be that it wanted a special branch off the repository and I pushed back. This is currently in master in the official repo.
- this is meant to trigger the meson subproject. I have 0.8.1 installed and the build fail because of that (it build the tests in the default target).
So we can keep the build broken until a release, or we can just accept it and move forward. Or disable the tests again.
There was a problem hiding this comment.
Yeah, the projects have a cyclic dependency so depending on an unreleased version is fine, until we want to have a release.
hfiguiere
force-pushed
the
test-build-fix
branch
from
90af323 to
e20b66f
Compare
done. |
|
libportal uses the post-release version bump scheme, so technically the main branch is already 0.9.0 (but still untagged) and projects can start requiring this version for features that will only exist in the 0.9.0 release. |
hfiguiere
force-pushed
the
test-build-fix
branch
from
e20b66f to
a1f822b
Compare
|
I started building in a fresh toolbox that has not libportal-devel. The subproject fetches 0.8.1 and thus the build fail. |
|
So I'm not sure in which circumstances this is supposed to work OOB, but with this PR it does in that case as well. |
|
ping @smcv |
There was a problem hiding this comment.
If x-d-p needs an unreleased libportal, I would still prefer that to be resolved by releasing libportal, returning x-d-p git main to a state where it is releasable. But I'm not a particularly active maintainer in this project, so if other maintainers have different ideas I'm not going to veto them.
smcv
dismissed
their stale review
My opinion is not a blocker if other maintainers disagree with it
The notification API for the notification test is only in current git (0.9.0). Without this the test fail to build if you have the current release installed: this triggers the meson subproject build. Signed-off-by: Hubert Figuière <[email protected]>
hfiguiere
force-pushed
the
test-build-fix
branch
from
a1f822b to
f5f48e8
Compare
|
Merging this would help https://gitlab.gnome.org/GNOME/xdg-desktop-portal-gnome/-/merge_requests/159 to pass. |
|
libportal 0.9.0 has been released so this is unblocked now |
GeorgesStavracas
removed this pull request from the merge queue due to a manual request
Without this the build fail if you have libportal 0.8.1 installed
This is needed for the notification work.