Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Depend on a recent enough version of libportal #1527

Merged
merged 1 commit into from
Dec 21, 2024
Merged

test: Depend on a recent enough version of libportal #1527

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion meson.build
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ geoclue_dep = dependency(
)
libportal_dep = dependency(
'libportal',
version: '>= 0.8.1',
version: '>= 0.9.0',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

libportal 0.9.0 has not been released yet. If x-d-p needs a newer libportal than 0.8.1, then we need a libportal release first.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the thing is:

  1. it's only for the test
  2. it used to be that it wanted a special branch off the repository and I pushed back. This is currently in master in the official repo.
  3. this is meant to trigger the meson subproject. I have 0.8.1 installed and the build fail because of that (it build the tests in the default target).

So we can keep the build broken until a release, or we can just accept it and move forward. Or disable the tests again.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, the projects have a cyclic dependency so depending on an unreleased version is fine, until we want to have a release.

required: get_option('libportal'),
fallback: ['libportal', 'libportal_dep'],
default_options: [
Expand Down
Loading