Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

➕ Support Drag and Select feature #175 #660

Open
wants to merge 23 commits into
base: main
Choose a base branch
from
Open

➕ Support Drag and Select feature #175 #660

wants to merge 23 commits into from
+398 −11

Conversation

WeiJun0507
Copy link

@WeiJun0507 WeiJun0507 commented Nov 9, 2024 •
edited by AlexV525
Loading

According to the previous PR #465, I have made a revamped version of the Drag and Select feature.

In this new pull request,

  1. Drag select logic has been moved into the Provider class to separate the UI layer and the Logic layer.
  2. Support Edge auto-scrolling using EdgeDraggingAutoScroller.
  3. Better position calculation to enhance the drag performance.

@AlexV525 AlexV525 mentioned this pull request Nov 10, 2024
Closed
@firecannons firecannons mentioned this pull request Nov 11, 2024
Open
AlexV525
AlexV525 reviewed Nov 11, 2024
View reviewed changes
lib/src/provider/asset_picker_provider.dart Outdated Show resolved Hide resolved
lib/src/provider/asset_picker_provider.dart Outdated Show resolved Hide resolved
lib/src/delegates/asset_picker_builder_delegate.dart Outdated Show resolved Hide resolved
lib/src/provider/asset_picker_provider.dart Outdated Show resolved Hide resolved
@WeiJun0507
Copy link
Author

I have updated the code upon the above suggestion. Please re-review this PR again

@AlexV525
Copy link
Member

AlexV525 commented Dec 3, 2024

Now we have the AssetGridDragSelectionCoordinator that takes care of all calculations. The feature now supports selecting assets through long press, horizontal drag, and pan gestures. Anyone who is watching this, please feel free to give feedback!

@AlexV525 AlexV525 mentioned this pull request Dec 3, 2024
Open
@WeiJun0507
Copy link
Author

I am currently taking sick leave, and will endeavor to review and provide feedback as soon as possible. Thank you very much for your hard work; I truly appreciate it.❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexV525 AlexV525 AlexV525 requested changes

@LeGoffMael LeGoffMael Awaiting requested review from LeGoffMael LeGoffMael is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WeiJun0507 @AlexV525