Specify minio env vars in integration tests #3001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eduardo Apolinario <[email protected]>
eapolinario
requested review from
wild-endeavor,
kumare3,
pingsutw,
cosmicBboy,
samhita-alla,
thomasjpfan and
Future-Outlier
as code owners
wild-endeavor
approved these changes
Dec 13, 2024
shuyingliang
pushed a commit
to shuyingliang/flytekit
that referenced
this pull request
Dec 14, 2024
Signed-off-by: Eduardo Apolinario <[email protected]> Co-authored-by: Eduardo Apolinario <[email protected]> Signed-off-by: Shuying Liang <[email protected]>
wild-endeavor
pushed a commit
that referenced
this pull request
Dec 16, 2024
Signed-off-by: Eduardo Apolinario <[email protected]> Co-authored-by: Eduardo Apolinario <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
In flyteorg/flyte#5947 we stopped emitting the config the storage section to instruct clients to use the minio credentials. This was released in flytectl 0.9.3 (which was yanked due in flyteorg/flyte#6100) and present in 0.9.4.
What changes were proposed in this pull request?
We specify environment variables to instruct the flytekit boto client to hit minio.
How was this patch tested?
Ran tests locally.
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link