-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Bavaria #269 #483
base: main
Are you sure you want to change the base?
Fix Bavaria #269 #483
Conversation
4961d11
to
bb06008
Compare
bb06008
to
4c4498c
Compare
Hey @XSpielinbox, now with the observance type, I would propose the following. We add the assumption day for Bavaria as observance and override them with city configuration with the type public holiday. |
4c4498c
to
541863d
Compare
@derTobsch Sure, adding it as an observance would be an improvement. Therefore I see the following options:
Please let me know, which option you would favor. Then I would update the PR accordingly. |
Signed-off-by: XSpielinbox <[email protected]>
541863d
to
0d9dc7c
Compare
🐞 closes #269
@derTobsch would you be ok with leaving Augsburg's special holiday, but moving assumption day up one level to Bavaria as it is applicable to the majority of cities and not only the few that currently exist as more specific cases?
As these non ISO 3166 cities then would have no holidays I have removed them, as I would see ADR 001 as not applicable as there are just to many cities for which I don't see the value to have empty configurations for them.
But if you wish, I could also leave them empty and add empty configurations for other major Bavarian cities.