Test recipes #92
Closed
Test recipes #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 12, 2024
Closed
simesy
reviewed
Jul 12, 2024
| @@ -38,3 +38,6 @@ drush-backups | |||
| .phpunit.result.cache | |||
| *.sql | |||
| *.zip | |||
|
|
|||
| # Recipes | |||
| web/recipes/contrib | |||
There was a problem hiding this comment.
I already added web/recipes in feature/recipes.
| volumes: | ||
| ${{ github.workspace }}:/app | ||
| run: | | ||
| cd web && php -d memory_limit=512M core/scripts/drupal install recipes/contrib/frees-auce-recipes/ce |
| @@ -0,0 +1,34 @@ | |||
| name: Recipe Test | |||
There was a problem hiding this comment.
This is good for now, but FYI once everything is working we will replace the test that uses drush si minimal --existing-config -y
| @@ -113,7 +111,7 @@ | |||
| "web/modules/custom/{$name}": ["type:drupal-custom-module"], | |||
| "web/profiles/contrib/{$name}": ["type:drupal-profile"], | |||
| "web/profiles/custom/{$name}": ["type:drupal-custom-profile"], | |||
| "web/recipes/{$vendor}{$name}": ["type:drupal-recipe"], | |||
| "web/recipes/contrib/{$vendor}{$name}": ["type:drupal-recipe"], | |||
There was a problem hiding this comment.
Note that i changed this to just be {$vendor}
| @@ -97,8 +97,6 @@ | |||
| "[web-root]/sites/development.services.yml": false, | |||
| "[web-root]/sites/example.settings.local.php": false, | |||
| "[web-root]/sites/example.sites.php": false, | |||
| "[web-root]/sites/default/default.services.yml": false, | |||
| "[web-root]/sites/default/default.settings.php": false, | |||
There was a problem hiding this comment.
Please don't add these back. Not needed with drush.
| @@ -0,0 +1,13 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
I changed this in feature/recipes to be scratch-from-recipes-wip.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please describe your changes in detail according to the information below.