-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add testmon in pytest #1209
feat: add testmon in pytest #1209
Conversation
…ts-that-are-affected-by-the-open-pr' of github.com:georgia-tech-db/eva into 1200-use-pytest-testmon-to-run-the-long-integration-tests-that-are-affected-by-the-open-pr
Do we also need to push the |
It will be generated from the |
@@ -201,6 +212,11 @@ jobs: | |||
- restore_cache: | |||
keys: | |||
- v1-model_cache-{{ checksum "setup.py" }} | |||
|
|||
# Restore testmondata | |||
- restore_cache: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not something critical, shall we only restore the cache for the open PR long integration cached test?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually I tried a different way to simplify the circle ci config. Please take a look.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I meant it is currently restoring the cache for any test. Is that expected? Do we want to rerun everything for staging
and master
? Or we should run only affected as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel we should run all the testcases for staging/master.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- We are running all the testcases for staging/master. We use
--testmon-noselect
for all staging and master. - Yes. We are restoring the staging cache key for any test, but they are only used for open PRs. It avoids all the
when condition
to make circle ci simple. PS: I can not make when condition work for restoring cache.
…ts-that-are-affected-by-the-open-pr' of github.com:georgia-tech-db/eva into 1200-use-pytest-testmon-to-run-the-long-integration-tests-that-are-affected-by-the-open-pr
@jiashenC @gaurav274 This PR is ready. Please review. Thanks. |
Add
testmon
in pytest